os configure: Locate the boot partition w/o using the device-type.json's partition field #2901
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thgreasi
force-pushed
the
balena-device-init-v-8-1-0
branch
7 times, most recently
from
bd042dc to
b64723f
Compare
myarmolinsky
approved these changes
Dec 20, 2024
thgreasi
force-pushed
the
balena-device-init-v-8-1-0
branch
from
b64723f to
245a966
Compare
kb2ma
reviewed
Dec 20, 2024
thgreasi
force-pushed
the
balena-device-init-v-8-1-0
branch
from
245a966 to
08d2d3c
Compare
Change-type: patch
thgreasi
force-pushed
the
balena-device-init-v-8-1-0
branch
from
08d2d3c to
3ed7317
Compare
…n's partition field Update balena-device-init from 8.0.0 to 8.1.0 Change-type: minor
thgreasi
force-pushed
the
balena-device-init-v-8-1-0
branch
from
3ed7317 to
c36c530
Compare
…ce-type.json contents Change-type: minor
thgreasi
force-pushed
the
balena-device-init-v-8-1-0
branch
from
c36c530 to
6281bb1
Compare
kb2ma
reviewed
Dec 26, 2024
kb2ma
reviewed
Dec 26, 2024
| const command: string[] = [ | ||
| `os configure ${tmpMatchingDtJsonPartitionPath}`, | ||
| '--device-type jetson-nano', | ||
| '--version 6.0.13', |
There was a problem hiding this comment.
You can remove the version option now that getOsVersionFromImage() reads from the image. It also would provide another implicit test.
kb2ma
reviewed
Dec 26, 2024
| const command: string[] = [ | ||
| `os configure ${tmpNonMatchingDtJsonPartitionPath}`, | ||
| '--device-type jetson-nano', | ||
| '--version 6.1.25', |
There was a problem hiding this comment.
You can remove this version option now like for the preceding test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On top of #2899, so let's get that in first for better debugging in case of an issue.
Update balena-device-init from 8.0.0 to 8.1.0
Depends-on: balena-io-modules/balena-device-init#47
Change-type: patch