Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Big Serial to Type.sbvr #99

Merged
merged 1 commit into from
Apr 9, 2024
Merged

Conversation

joshbwlng
Copy link
Contributor

Change-type: patch

@joshbwlng joshbwlng self-assigned this Apr 8, 2024
@joshbwlng joshbwlng enabled auto-merge April 8, 2024 04:12
@joshbwlng joshbwlng requested review from Page- and thgreasi April 8, 2024 04:12
@joshbwlng joshbwlng force-pushed the joshbwlng/big-serial-sbvr branch from 43da485 to c60c49f Compare April 8, 2024 05:14
@joshbwlng joshbwlng changed the title Add Big Serial to Types.sbvr Add Big Serial to Type.sbvr Apr 8, 2024
Change-type: patch
@joshbwlng joshbwlng force-pushed the joshbwlng/big-serial-sbvr branch from c60c49f to c5add0f Compare April 9, 2024 01:36
@thgreasi
Copy link
Contributor

thgreasi commented Apr 9, 2024

That should probably be a minor right?

@joshbwlng joshbwlng merged commit 583ba11 into master Apr 9, 2024
47 checks passed
@joshbwlng joshbwlng deleted the joshbwlng/big-serial-sbvr branch April 9, 2024 10:02
@@ -14,6 +14,9 @@ Term: Big Integer
Term: Serial
Concept Type: Integer
Note: An auto-incrementing 'Integer'.
Term: Big Serial
Concept Type: Integer
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@joshbwlng I realized this right as I clicked approve that it should probably be

Concept Type: Big Integer

for clarity (although it'll work the same either way)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants