Return ISODateString instead of date

The internal and external representation of the returned object from pinejs should be consistent.
Pinejs internal interface will return date or date time fields as date object. For the external interface the object is JSON.stringified so that date becomes an ISO string anyway.

Change-type: major
Signed-off-by: fisehara <[email protected]>

src/types/date-time.ts

@@ -10,10 +10,13 @@ export const types = {
 };
 
 export const fetchProcessing = (data: any) => {
-	if (data == null || data instanceof Date) {
+	if (data == null) {
 		return data;
 	}
-	return new Date(data);
+	if (!(data instanceof Date)) {
+		data = new Date(data);
+	}
+	return data.toISOString();
 };
 
 export const nativeFactTypes = {

src/types/date.ts

@@ -10,10 +10,13 @@ export const types = {
 };
 
 export const fetchProcessing = (data: any) => {
-	if (data == null || data instanceof Date) {
+	if (data == null) {
 		return data;
 	}
-	return new Date(data);
+	if (!(data instanceof Date)) {
+		data = new Date(data);
+	}
+	return data.toISOString();
 };
 
 export const nativeFactTypes = {

src/types/time.ts

@@ -12,7 +12,7 @@ export const types = {
 export const fetchProcessing = (data: any) => {
 	if (data != null) {
 		// We append the date of the epoch so that we can parse this as a valid date.
-		return new Date('Thu, 01 Jan 1970 ' + data);
+		return new Date('Thu, 01 Jan 1970 ' + data).toISOString();
 	}
 	return data;
 };

test/Date Time.js

@@ -3,9 +3,9 @@ import * as helpers from './helpers';
 helpers.describe('Date Time', function (test) {
 	const now = new Date();
 	describe('fetchProcessing', function () {
-		test.fetch(now, now);
-		test.fetch(now.toString(), now);
-		test.fetch(now.getTime(), now);
+		test.fetch(now, now.toISOString());
+		test.fetch(now.toString(), new Date(now.toString()).toISOString());
+		test.fetch(now.getTime(), new Date(now.getTime()).toISOString());
 		test.fetch(null, null);
 	});
 

test/Date.js

@@ -3,9 +3,9 @@ import * as helpers from './helpers';
 helpers.describe('Date', function (test) {
 	const now = new Date();
 	describe('fetchProcessing', function () {
-		test.fetch(now, now);
-		test.fetch(now.toString(), now);
-		test.fetch(now.getTime(), now);
+		test.fetch(now, now.toISOString());
+		test.fetch(now.toString(), new Date(now.toString()).toISOString());
+		test.fetch(now.getTime(), new Date(now.getTime()).toISOString());
 		test.fetch(null, null);
 	});
 

test/Time.js

@@ -6,7 +6,10 @@ helpers.describe('Time', function (test) {
 	now.setMonth(0);
 	now.setDate(1);
 	describe('fetchProcessing', function () {
-		test.fetch(now.toTimeString(), now);
+		test.fetch(
+			now.toTimeString(),
+			new Date('Thu, 01 Jan 1970 ' + now.toTimeString()).toISOString(),
+		);
 		test.fetch(null, null);
 	});