-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
minor: allow passing custom assets to start SB protected CM4 #324
Conversation
71b05d1
to
2ef116e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm with a small nitpick - however let's wait for Akis to review.
examples/usbboot.ts
Outdated
|
||
if (flags.help) { | ||
console.log( | ||
'Usage: ts-node usbboot.js --bootImageFolder <bootImageFolder> --source <image>', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this example file meant to used directly?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For demo purposes mostly
I do use it (also multi-destination) as a poor man CLI
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, that's the reason I'm asking -- if it's meant to be relied upon, then it should be a proper script shipped with the package and not merely an example (which is not really maintained or tested that it works).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If your concern is that would become de-facto production, it shouldn't. We still need a proper place to hook this up (the CLI, a new etcherCLI, a proper script in this repo or somewhere else)
Looks good to me, once Alex's comments are addressed feel free to merge |
524228c
to
f7629d6
Compare
f7629d6
to
bafb2d7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a bunch of nitpicks so I would ask you to self approve if it was possible - let me know if they are not worth addressing and I will approve.
bafb2d7
to
d13f627
Compare
This PR adds the ability pass a folder with second stage boot assets as parameter when initiating usbbootscanner.
This is to allow end-user to provide config.txt and signed boot.img required to get a secureboot-enabled CM4 to attach as a mass-storage device and be reflashed.
This mostly only expose the changes made in balena-io-modules/node-raspberrypi-usbboot#53 in examples.