Make the baseUrl parameter required for refreshToken()

Resolves: #96 Change-type: major Signed-off-by: Thodoris Greasidis <[email protected]>
balena-io-modules · Mar 12, 2021 · 12fd8c0 · 12fd8c0
1 parent 66cc43e
commit 12fd8c0
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 0 deletions.
diff --git a/lib/request.ts b/lib/request.ts
@@ -447,6 +447,9 @@ export function getRequest({
 		if (auth == null) {
 			throw new Error('Auth module not provided in initializer');
 		}
+		if (!baseUrl) {
+			throw new Error('The baseUrl parameter is required');
+		}
 
 		let response: BalenaRequestResponse<string>;
 		try {

diff --git a/tests/token.spec.coffee b/tests/token.spec.coffee
@@ -239,6 +239,12 @@ describe 'Request (token):', ->
 				auth.setKey(johnDoeFixture.token)
 				mockServer.get('/user/v1/refresh-token').thenReply(200, janeDoeFixture.token)
 
+			it 'should error when the baseUrl is not provided', ->
+				auth.getKey().then (savedToken) ->
+					m.chai.expect(savedToken).to.equal(johnDoeFixture.token)
+					promise = request.refreshToken({})
+					m.chai.expect(promise).to.be.rejectedWith('The baseUrl parameter is required')
+
 			it 'should refresh the token', ->
 				auth.getKey().then (savedToken) ->
 					m.chai.expect(savedToken).to.equal(johnDoeFixture.token)