Skip to content

Commit

Permalink
Does not accept v1 manifest for builds
Browse files Browse the repository at this point in the history
Docker Image Format v1 and Docker Image manifest version 2, schema 1 support is disabled by default and will be removed in an upcoming release.

Change-type: major
  • Loading branch information
otaviojacobi committed Jul 12, 2024
1 parent b850e25 commit 1e9afb9
Showing 1 changed file with 6 additions and 10 deletions.
16 changes: 6 additions & 10 deletions test/multibuild/build.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -322,8 +322,8 @@ describe('Resolved project building', () => {
resolve(runBuildTask(newTask, docker, secretMap, buildVars));
})
.then((image) => {
expect(image).to.have.property('successful').that.equals(true);
return checkExists(image.name!);
expect(image).to.have.property('successful').that.equals(false);
expect(image).to.have.property('error').that.is.not.null;
})
.then((inspect: any) => {
expect(inspect).to.have.property('Architecture').that.equals('amd64');
Expand All @@ -349,14 +349,10 @@ describe('Resolved project building', () => {
const newTask = resolveTask(task, 'amd64', 'intel-nuc', resolveListeners);

resolve(runBuildTask(newTask, docker, secretMap, buildVars));
})
.then((image) => {
expect(image).to.have.property('successful').that.equals(true);
return checkExists(image.name!);
})
.then((inspect: any) => {
expect(inspect).to.have.property('Architecture').that.equals('amd64');
});
}).then((image) => {
expect(image).to.have.property('successful').that.equals(false);
expect(image).to.have.property('error').that.is.not.null;
});
});

it('should build using "platform" flag (v2 manifest) on third party registry', async () => {
Expand Down

0 comments on commit 1e9afb9

Please sign in to comment.