-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Github actions - ease testing and configurable path #27
Conversation
You can see example test results here https://github.com/DominicWatts/magento2-module-url-data-integrity-checker/actions |
I've put some keys in the actions - so they are publicly visible. However you can use github secrets https://github.com/DominicWatts/Faker/blob/master/.github/workflows/phpstan.yml#L10
But that needs configuring in each repo Anyway, worse case scenario I hope you consider the introduction of a configurable path. |
Thanks @DominicWatts! Will try to have a proper look in one of the next few weeks. But first remark would be if you could split the PR into two parts, where the new functionality is added in one PR, and the github actions are in a second PR. |
I installed in a multi-container environment and the tmp var was not mounted and therefore was not shared between containers. I recommend that you allow the path of the json files to be configurable.
Also I took the time to create github actions based on your Makefile. Easier to test code submissions.