Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Pool page redirects to new UI #5897

Merged
merged 2 commits into from
Sep 11, 2024

Conversation

garethfuller
Copy link
Collaborator

No description provided.

Copy link

vercel bot commented Jul 30, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
beta-app-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 30, 2024 11:41am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
app-v2 ⬜️ Ignored (Inspect) Visit Preview Jul 30, 2024 11:41am

Copy link
Collaborator

@agualis agualis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Although we have "Try zen" banner on top of the page, someone could get confused when being redirected. I will tell Cosme Fulanito about this change.

@alter-eggo
Copy link
Collaborator

alter-eggo commented Jul 30, 2024

I have same thought as @agualis , this is not was user expects by clicking on a pool

@garethfuller
Copy link
Collaborator Author

@agualis @alter-eggo I should have put this in the description, this is a prep PR, not going live right now. When it does, there won't be a pool list on v2 either, so no one will be able to click on pools. It just introduces the redirects for all the external links, linking to our v2 pool pages. We can't do this at the domain level because of the hash router.

@garethfuller garethfuller merged commit 3fd8071 into master Sep 11, 2024
6 checks passed
@garethfuller garethfuller deleted the chore/add-pool-page-redirects branch September 11, 2024 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants