Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix: Allow staking of Avalanche FX pool #3835

Merged
merged 1 commit into from
Aug 2, 2023

Conversation

timjrobinson
Copy link
Contributor

Description

Currently there is no way to stake tokens for the Avalanche FX pool (0x55bec22f8f6c69137ceaf284d9b441db1b9bfedc000200000000000000000011) via the UI because of two reasons:

  • The staking card is currently hidden when it is a custom pool type that has a custom way of adding liquidity (FX/Gyro)
  • The pool wasn't in the staking approve list, which made the stake button not appear in the porfolio page.

This fixes both those issues.

I did notice the Gyro pools aren't on the staking lists, should they be so that users can stake their LBP through the Balancer UI?

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How should this be tested?

  • Ensure the add liquidity and stake cards appear as normal on normal pools (e.g. /#/avalanche/pool/0x054e7b0c73e1ee5aed6864fa511658fc2b54bcaa000000000000000000000015)
  • Ensure the stake card doesn't appear on a pool without staking (e.g. /#/avalanche/pool/0x3396cca90c9335565ecdbae3a260dafb13a7959e000200000000000000000018)
  • Ensure the custom card + staking appears on a custom pool (e.g. /#/avalanche/pool/0x55bec22f8f6c69137ceaf284d9b441db1b9bfedc000200000000000000000011)
  • Ensure no cards appear on LBP pools (e.g. /#/ethereum/pool/0x84d9288a62132b9e9097aaefd2caea7d5ce966c50002000000000000000005ac)

Visual context

staking-card

Checklist:

  • I have performed a self-review of my own code
  • I have requested at least 1 review (If the PR is significant enough, use best judgement here)
  • I have commented my code where relevant, particularly in hard-to-understand areas
  • If package-lock.json has changes, it was intentional.
  • The base of this PR is master if hotfix, develop if not

@vercel
Copy link

vercel bot commented Aug 2, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
beta-app-v2 ✅ Ready (Inspect) Visit Preview Aug 2, 2023 5:22am
1 Ignored Deployment
Name Status Preview Updated (UTC)
app-v2 ⬜️ Ignored (Inspect) Aug 2, 2023 5:22am

@timjrobinson timjrobinson merged commit 3874b86 into master Aug 2, 2023
4 checks passed
@timjrobinson timjrobinson deleted the hf/fix-staking-fx-pool branch August 2, 2023 07:40
@timjrobinson timjrobinson restored the hf/fix-staking-fx-pool branch August 2, 2023 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants