hotfix: skip faucet refill error

[alter-eggo]

Description

See title

Type of change

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• Dependency changes
• Code refactor / cleanup
• Documentation or wording changes
• Other

How should this be tested?

Please provide instructions so we can test. Please also list any relevant details for your test configuration.

• Test A
• Test B

Visual context

Please provide any relevant visual context for UI changes or additions. This could be static screenshots or a loom screencast.

Checklist:

• I have performed a self-review of my own code
• I have requested at least 1 review (If the PR is significant enough, use best judgement here)
• I have commented my code where relevant, particularly in hard-to-understand areas
• If package-lock.json has changes, it was intentional.
• The base of this PR is master if hotfix, develop if not

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
beta-app-v2	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jul 11, 2023 1:24pm

1 Ignored Deployment

Name	Status	Preview	Comments	Updated (UTC)
app-v2	⬜️ Ignored (Inspect)			Jul 11, 2023 1:24pm

[garethfuller]

Instead of adding multiple conditions here we should have a single catchall conditional like shouldCaptureError or similar.

[alter-eggo]

isn't shouldLogFailure actually that single catchall conditional?

[danielmkm]

think he means merge isUserError with isFaucetRefillError and call it shouldCaptureError

[alter-eggo]

if so, I don't understand the logic, why we need one more function here?

[garethfuller]

Sorry, I missed the context of the function these conditionals are in, this shouldLogFailure function is essentially what I'm asking for, but it's in the wrong place. We should have a global shouldCaptureError function in something like useErrors or the utils file Daniel created. We need a single source of truth for error handling.

[alter-eggo]

yeah, but I did it as hf to prevent failing errors in sentry, and Daniel did that pr in dev. do you think it's better to do this in dev branch?

[garethfuller]

Yeah fair enough, lets merge this and continue work on global handling.