fix: zkevm tx confirmation callback #3676
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
alter-eggo
approved these changes
Jul 11, 2023
timjrobinson
approved these changes
Jul 11, 2023
|
There is some additional logic that needs to be fixed here. |
timjrobinson
approved these changes
Jul 13, 2023
joehquak
referenced
this pull request
in Sobal/frontend-v2
Jul 30, 2023
* fix: Wait for 10 confirmations on zkevm * refactor: Use BalActionStep success/fail events * chore: Fix tests * chore: Move notification trigger to action
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
It's possible that zkevm rpc state mismatches/caching are causing problems with submitting transactions before approvals are finalized. Like we had already done for Polygon PoS, this PR introduces a 10 confirmation wait before we consider a tx finalized on zkevm.
Additionally, txListener was being used at two levels in several flows, we only need to listen in BalActionSteps and then emit the events to be handled at a higher level. This has been refactored where relevant.
Type of change
How should this be tested?
Checklist:
masterif hotfix,developif not