Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Pass reciept to submit vote button #3675

Merged
merged 1 commit into from
Jul 11, 2023
Merged

Conversation

garethfuller
Copy link
Collaborator

@garethfuller garethfuller commented Jul 10, 2023

Description

The submit vote button wasn't updating after a successful transaction because at some point the receipt prop had been removed. The button requires the transaction receipt state in order to present the confirmation indicator and button to close the modal instead of a button that prompts the user to resubmit the vote.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How should this be tested?

  • Submit a vote, check that the success state of the vote modal makes sense.

Checklist:

  • I have performed a self-review of my own code
  • I have requested at least 1 review (If the PR is significant enough, use best judgement here)
  • I have commented my code where relevant, particularly in hard-to-understand areas
  • If package-lock.json has changes, it was intentional.
  • The base of this PR is master if hotfix, develop if not

@vercel
Copy link

vercel bot commented Jul 10, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
beta-app-v2 ✅ Ready (Inspect) Visit Preview Jul 10, 2023 8:10pm
1 Ignored Deployment
Name Status Preview Updated (UTC)
app-v2 ⬜️ Ignored (Inspect) Jul 10, 2023 8:10pm

@garethfuller garethfuller merged commit f9ef1d4 into develop Jul 11, 2023
4 checks passed
@garethfuller garethfuller deleted the fix/vote-modal branch July 11, 2023 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants