refactor: Fetch allowances for vault only once in join flow #3642
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
alter-eggo
approved these changes
Jul 6, 2023
| @@ -90,12 +91,19 @@ export default function useTokenApprovalActions() { | |||
| } | |||
| } | |||
|
|
|||
| async function updateAllowancesFor(spender: string): Promise<void> { | |||
| await injectSpenders([spender]); | |||
| await refetchAllowances(); | |||
There was a problem hiding this comment.
cannot be in Promise.all?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Previously we were refetching vault allowances everytime the the user changed amounts in the join form, this was a side-effect of re-constructing approval actions required in the preview modal. This PR makes that allowance fetching optional for the get actions function and adds a separate function to ensure allowances are updated for a given spender. Then in the join pool provider, onBeforeMount, we just fetch allowances for the vault and skip the fetching for reconstructing the approval actions as token amounts are changed.
Type of change
How should this be tested?
Checklist:
masterif hotfix,developif not