Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Catch all user triggered errors #3628

Merged
merged 1 commit into from
Jul 5, 2023

Conversation

garethfuller
Copy link
Collaborator

@garethfuller garethfuller commented Jul 5, 2023

Description

There are more errors than just user-rejected errors that are triggered by the user and that we shouldn't treat as transaction errors. This PR adds a new function to capture them all and replaces the usage of the user-rejected function instead.

Type of change

  • Code refactor / cleanup

Checklist:

  • I have performed a self-review of my own code
  • I have requested at least 1 review (If the PR is significant enough, use best judgement here)
  • I have commented my code where relevant, particularly in hard-to-understand areas
  • If package-lock.json has changes, it was intentional.
  • The base of this PR is master if hotfix, develop if not

@vercel
Copy link

vercel bot commented Jul 5, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
beta-app-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 5, 2023 8:19am
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
app-v2 ⬜️ Ignored (Inspect) Jul 5, 2023 8:19am

@garethfuller garethfuller merged commit 389149f into develop Jul 5, 2023
4 checks passed
@garethfuller garethfuller deleted the refactor/user-triggered-errors branch July 5, 2023 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants