Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More ignoring of user errors and improvements to error handling #3621

Merged
merged 5 commits into from
Jul 4, 2023

Conversation

timjrobinson
Copy link
Contributor

@timjrobinson timjrobinson commented Jul 4, 2023

Description

  • Rename useTransactions where it's misspelt
  • Rename test file from user -> use.
  • Add more test cases for user errors found in sentry.
  • Change checks to regexes so they can match part of the error string instead of having to be an exact match.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • I have performed a self-review of my own code
  • I have requested at least 1 review (If the PR is significant enough, use best judgement here)
  • I have commented my code where relevant, particularly in hard-to-understand areas
  • If package-lock.json has changes, it was intentional.
  • The base of this PR is master if hotfix, develop if not

@vercel
Copy link

vercel bot commented Jul 4, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
beta-app-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 4, 2023 9:35am
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
app-v2 ⬜️ Ignored (Inspect) Jul 4, 2023 9:35am

@garethfuller garethfuller merged commit 323bc07 into develop Jul 4, 2023
@garethfuller garethfuller deleted the improve-user-rejected-errors branch July 4, 2023 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants