Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix - Improve allowance check on Gnosis Chain #3614

Merged
merged 1 commit into from
Jul 3, 2023

Conversation

timjrobinson
Copy link
Contributor

Description

  • Refetch allowances before running the isApprovalValid action as sometimes it won't pick up the newly approved allowance (especially on Gnosis chain).
  • Switch Gnosis chain to the official RPC as it seems to be more reliable than pokt.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How should this be tested?

  • Join a pool or stake on Gnosis Chain
  • Ensure you don't get any errors about not having enough allowance.

Checklist:

  • I have performed a self-review of my own code
  • I have requested at least 1 review (If the PR is significant enough, use best judgement here)
  • I have commented my code where relevant, particularly in hard-to-understand areas
  • If package-lock.json has changes, it was intentional.
  • The base of this PR is master if hotfix, develop if not

@vercel
Copy link

vercel bot commented Jul 3, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
beta-app-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 3, 2023 3:42pm
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
app-v2 ⬜️ Ignored (Inspect) Jul 3, 2023 3:42pm

@timjrobinson timjrobinson merged commit 488c93f into master Jul 3, 2023
@timjrobinson timjrobinson deleted the hotfix/refetch-allowances branch July 4, 2023 05:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants