Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix/add new available pools #3569

Merged
merged 1 commit into from
Jun 22, 2023
Merged

Conversation

agualis
Copy link
Collaborator

@agualis agualis commented Jun 22, 2023

Description

Adds a new NewVersionAvailable metadata property to announce new versions of pools without deprecating the old ones.

The logic can probably be refactored a bit further but I suggest waiting until we find more cases.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency changes
  • Code refactor / cleanup
  • Documentation or wording changes
  • Other

How should this be tested?

Please provide instructions so we can test. Please also list any relevant details for your test configuration.

  • Test A
  • Test B

Visual context

Please provide any relevant visual context for UI changes or additions. This could be static screenshots or a loom screencast.

Checklist:

  • I have performed a self-review of my own code
  • I have requested at least 1 review (If the PR is significant enough, use best judgement here)
  • I have commented my code where relevant, particularly in hard-to-understand areas
  • If package-lock.json has changes, it was intentional.
  • The base of this PR is master if hotfix, develop if not

@agualis agualis self-assigned this Jun 22, 2023
@vercel
Copy link

vercel bot commented Jun 22, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
beta-app-v2 ✅ Ready (Inspect) Visit Preview Jun 22, 2023 4:08pm
1 Ignored Deployment
Name Status Preview Updated (UTC)
app-v2 ⬜️ Ignored (Inspect) Jun 22, 2023 4:08pm

@agualis agualis changed the base branch from develop to master June 22, 2023 16:08
@agualis agualis requested a review from alter-eggo June 22, 2023 16:09
@agualis agualis merged commit 0a2f22b into master Jun 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants