Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Allowlisting #3568

Merged
merged 1 commit into from
Jun 22, 2023
Merged

Improve Allowlisting #3568

merged 1 commit into from
Jun 22, 2023

Conversation

timjrobinson
Copy link
Contributor

Description

  • Makes allowlisting create a new branch + PR per pool so that it doesn't force update the same PR when new pools come in
  • Add pool description to the allowlist request header.

Tested this in my personal fork and this is the result: timjrobinson#23

Type of change

  • New feature (non-breaking change which adds functionality)

Checklist:

  • I have performed a self-review of my own code
  • I have requested at least 1 review (If the PR is significant enough, use best judgement here)
  • I have commented my code where relevant, particularly in hard-to-understand areas
  • If package-lock.json has changes, it was intentional.
  • The base of this PR is master if hotfix, develop if not

- Make it create a new PR per pool so that it doesn't force update the
  same PR when new pools come in
- Add pool description to the allowlist request header.
@vercel
Copy link

vercel bot commented Jun 22, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
beta-app-v2 ✅ Ready (Inspect) Visit Preview Jun 22, 2023 1:27pm
1 Ignored Deployment
Name Status Preview Updated (UTC)
app-v2 ⬜️ Ignored (Inspect) Jun 22, 2023 1:27pm

@timjrobinson timjrobinson merged commit 9009730 into develop Jun 22, 2023
4 checks passed
@timjrobinson timjrobinson deleted the improve-allowlist-pr branch June 22, 2023 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants