fix: Limit swap exits (#3945)

* fix: Limit swap exits to deep pools * chore: Add comment
balancer · Aug 11, 2023 · c229197 · c229197
1 parent 67a38b9
commit c229197
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 6 deletions.
diff --git a/src/components/forms/pool_actions/WithdrawForm/WithdrawForm.vue b/src/components/forms/pool_actions/WithdrawForm/WithdrawForm.vue
@@ -9,7 +9,6 @@ import useVeBal from '@/composables/useVeBAL';
 import WithdrawPreviewModal from './components/WithdrawPreviewModal/WithdrawPreviewModal.vue';
 import { useTokens } from '@/providers/tokens.provider';
 import {
-  isPreMintedBptType,
   tokensListExclBpt,
   usePoolHelpers,
 } from '@/composables/usePoolHelpers';
@@ -57,6 +56,7 @@ const {
   validAmounts,
   hasBpt,
   shouldUseRecoveryExit,
+  canSwapExit,
 } = useExitPool();
 
 const { isWrappedNativeAssetPool } = usePoolHelpers(pool);
@@ -76,8 +76,8 @@ const tokensList = computed(() => tokensListExclBpt(pool.value));
 
 // Limit token select modal to a subset.
 const subsetTokens = computed((): string[] => {
-  if (!shouldUseRecoveryExit.value && isPreMintedBptType(pool.value.poolType))
-    return [];
+  // Returning an empty array means all tokens are presented in the modal.
+  if (!shouldUseRecoveryExit.value && canSwapExit.value) return [];
 
   if (isWrappedNativeAssetPool.value)
     return [nativeAsset.address, ...tokensList.value];

diff --git a/src/providers/local/exit-pool.provider.ts b/src/providers/local/exit-pool.provider.ts
@@ -186,12 +186,15 @@ export const exitPoolProvider = (
     shouldSignRelayer.value ? [relayerApprovalAction.value] : []
   );
 
+  const canSwapExit = computed(
+    (): boolean => isDeep(pool.value) && isPreMintedBptType(pool.value.poolType)
+  );
+
   const shouldUseSwapExit = computed(
     (): boolean =>
       isSingleAssetExit.value &&
-      isDeep(pool.value) &&
-      isPreMintedBptType(pool.value.poolType) &&
-      !includesAddress(pool.value.tokensList, singleAmountOut.address)
+      !includesAddress(pool.value.tokensList, singleAmountOut.address) &&
+      canSwapExit.value
   );
 
   const shouldUseGeneralisedExit = computed(
@@ -604,6 +607,7 @@ export const exitPoolProvider = (
     relayerSignature,
     relayerApprovalTx,
     shouldUseSwapExit,
+    canSwapExit,
     shouldUseRecoveryExit,
 
     // methods