Hotfix: fix reward tokens apr breakdown (DM) (#3937)

* chore: Add migration notices (#3934) * 1.118.1 * fix reward tokens apr breakdown --------- Co-authored-by: Tim Robinson <[email protected]> Co-authored-by: Automated Version Bump <[email protected]> Co-authored-by: Fábio Mendes <[email protected]>
balancer · Aug 10, 2023 · 4bc4783 · 4bc4783 · vercel · Aug 10, 2023
1 parent b43b933
commit 4bc4783
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 12 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@balancer/frontend-v2",
-  "version": "1.118.0",
+  "version": "1.118.1",
   "engines": {
     "node": "=16",
     "npm": ">=8"

diff --git a/src/components/tooltips/APRTooltip/components/StakingBreakdown.vue b/src/components/tooltips/APRTooltip/components/StakingBreakdown.vue
@@ -6,7 +6,7 @@ import { bnum } from '@/lib/utils';
 import { Pool } from '@/services/pool/types';
 import { AprBreakdown } from '@balancer-labs/sdk';
 import { useTokens } from '@/providers/tokens.provider';
-import { hasBalEmissions } from '@/composables/useAPR';
+import { hasBalEmissions, hasStakingRewards } from '@/composables/useAPR';
 
 /**
  * TYPES
@@ -84,13 +84,15 @@ const breakdownItems = computed((): Array<any> => {
   }
 
   if (hasRewardTokens.value) {
-    if (isMinMaxSame.value) {
+    if (isMinMaxSame.value && minBalAPR.value > 0) {
       items.push(['BAL', minBalAPR.value]);
     }
 
     const rewardAprTokens = apr.value?.rewardAprs.breakdown;
     if (rewardAprTokens) {
       Object.keys(rewardAprTokens).forEach(address => {
+        if (rewardAprTokens[address] === 0) return;
+
         items.push([
           getToken(address)?.symbol || 'Rewards',
           rewardAprTokens[address],
@@ -116,7 +118,10 @@ const breakdownItems = computed((): Array<any> => {
       </div>
     </div>
     <template v-else>
-      <BalBreakdown v-if="hasBalEmissions(apr)" :items="breakdownItems">
+      <BalBreakdown
+        v-if="hasBalEmissions(apr) || hasStakingRewards(apr)"
+        :items="breakdownItems"
+      >
         <div class="flex items-center">
           {{ unboostedTotalAPR }}
           <span class="ml-1 text-xs text-secondary">
@@ -134,12 +139,6 @@ const breakdownItems = computed((): Array<any> => {
           </span>
         </template>
       </BalBreakdown>
-      <div v-else-if="hasRewardTokens" class="flex items-center">
-        {{ fNum(rewardTokensAPR, FNumFormats.bp) }}
-        <span class="ml-1 text-xs text-secondary">
-          {{ $t('staking.stakingApr') }}
-        </span>
-      </div>
     </template>
   </div>
 </template>