feat: v3 boosted adds/removes #146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
agualis
commented
Nov 6, 2024
| ...token.underlyingToken, | ||
| address: token.underlyingToken?.address as Address, | ||
| decimals: token.underlyingToken?.decimals as number, | ||
| index, //TODO: review that this index is always the expected one |
There was a problem hiding this comment.
@gareth This works with the reference boosted pool works but I have to double check this with the SDK team.
garethfuller
reviewed
Nov 6, 2024
garethfuller
approved these changes
Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unbalanced adds for v3 boosted pools and proportional removes.
Note that
proportional inputsare disabled until the SDK implements calculateProportionalAmounts for boosted pools.Note that single boosted removes will not be supported by the SDK in this first iteration.
Also includes some preparation code for
nested boosted pools.Boosted pool to test with:
https://mono-test-v3-git-feat-v3boostedadds-balancer.vercel.app/pools/sepolia/v3/0x6dbdd7a36d900083a5b86a55583d90021e9f33e8
adds-removesBoostedV3.mp4