Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix pools to ignore filter #558

Merged
merged 4 commits into from
Dec 21, 2023
Merged

Fix pools to ignore filter #558

merged 4 commits into from
Dec 21, 2023

Conversation

brunoguerios
Copy link
Member

A few conditions lead to SDK failing to route a valid swap:

  • poolsToIgnore file lists pools from all chains
  • poolsToIgnore filter was comparing pool addresses by truncating pool ids

Problem:

  • 2 different pools had different ids, but the same address (on different chains)

Fix:

  • update poolsToIgnore filter to compare pool ids instead of addresses

Extra:

  • add a swapDebug example to facilitate swap debugging within the SDK

@brunoguerios brunoguerios self-assigned this Dec 21, 2023
@brunoguerios brunoguerios merged commit 901c7bb into develop Dec 21, 2023
3 checks passed
@brunoguerios brunoguerios deleted the fix-pools-to-ignore-filter branch December 21, 2023 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@garethfuller garethfuller garethfuller approved these changes

@gmbronco gmbronco Awaiting requested review from gmbronco

Assignees

@brunoguerios brunoguerios

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brunoguerios @garethfuller