Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding chunkSize param to multicall fetchPools function; #494

Closed
wants to merge 4 commits into from
Closed

Adding chunkSize param to multicall fetchPools function; #494

wants to merge 4 commits into from

Conversation

lgahdl
Copy link
Contributor

@lgahdl lgahdl commented Jul 20, 2023

No description provided.

@lgahdl lgahdl requested a review from brunoguerios July 20, 2023 21:38
@lgahdl
Copy link
Contributor Author

lgahdl commented Jul 20, 2023

Needs this PR approved to work:
balancer/balancer-sor#399

Luiz Gustavo Abou Hatem De Liz added 3 commits July 21, 2023 16:21
fixing Lint error;
8bafbe3 
removing "discard chunk" functionality;
Fixing lint;
2f708c9
Fixing Lint
513f08f
@johngrantuk
Copy link
Member

At the moment we could possibly be discarding a chunk of pools that are not broken which could cause issues if the pool of interest is within the chunk.
One possible investigation is to figure out how to narrow down a chunk.
Not a priority for now as we investigate source of issue with poolQuery

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brunoguerios brunoguerios Awaiting requested review from brunoguerios

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lgahdl @johngrantuk