Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rolling back to use multicall instead of poolDataQueries contract; #493

Merged
merged 2 commits into from
Jul 20, 2023
Merged

Rolling back to use multicall instead of poolDataQueries contract; #493

merged 2 commits into from
Jul 20, 2023

Conversation

lgahdl
Copy link
Contributor

@lgahdl lgahdl commented Jul 19, 2023

No description provided.

gmbronco
gmbronco reviewed Jul 19, 2023
View reviewed changes
Copy link
Contributor

@gmbronco gmbronco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't test the code, but I'd say we should merge it asap and refactor to repositories later re-adding poolsQuery as an alternative rather than a replacement

balancer-js/src/modules/data/index.ts
poolDataQueries: networkConfig.addresses.contracts.poolDataQueries,
vault: networkConfig.addresses.contracts.vault,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we make poolDataQueries and multicall as data source implementing Findable? Then it would be very easy to change between sources for onchain data and use multicall or queries.

balancer-js/src/modules/data/pool/subgraphOnChain.ts
this.poolDataQueries = options.poolDataQueries;
this.vault = options.vault;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pools subgraph + onchain could be just merging two data sources into one. It could be fetching subgraph data first and onchain data later. Both subgraph and onchain should have the same interface, just returning a different data schemas. Right now multicall is a custom class, same with pools query.

@lgahdl
Copy link
Contributor Author

lgahdl commented Jul 19, 2023

I didn't test the code, but I'd say we should merge it asap and refactor to repositories later re-adding poolsQuery as an alternative rather than a replacement

I agree!

brunoguerios
brunoguerios approved these changes Jul 20, 2023
View reviewed changes
Copy link
Member

@brunoguerios brunoguerios left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job!

@brunoguerios brunoguerios merged commit 9a3b79e into develop Jul 20, 2023
@brunoguerios brunoguerios deleted the rollback-to-multicall branch July 20, 2023 00:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gmbronco gmbronco gmbronco left review comments

@brunoguerios brunoguerios brunoguerios approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lgahdl @brunoguerios @gmbronco