-
Notifications
You must be signed in to change notification settings - Fork 385
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CSV Downloads #153
CSV Downloads #153
Conversation
Looking over the example CSV export.
|
+1 re: tim's suggestions (minus fees, I think fees should be under a different reporting section) |
I agree that looking at this as a end user facing consumable rather than a dev facing item is a good way to think about this and i'll keep that in mind going forward.
everything else i'll make changes for ASAP, i've added those action items to the pull-request description, let me know if i've missed something. |
@mahmoudimus @mjallday Cool. Re: fees I just brought it up because marketplaces have requested it, but I think you're right that it'll be a pain to implement and invoice reports already will allow them to match the amounts with their bank accounts. |
@timnguyen new csv download with updates. i'm aware the dashboard link gives a 404 right now :) |
@mjallday Sorry, I don't know why I forgot to mention this, but i think we should also have account_name so that we have a kind of non-techie foreign key between marketplace systems and Balanced (and the techie people can use the account_uri). Have we gone through and decided order of columns? Otherwise, looks good. |
NOT ready to merge
transaction_id
amount
should be formatted as $1,000.00