Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSV Downloads #153

Merged
merged 22 commits into from
May 28, 2013
Merged

CSV Downloads #153

merged 22 commits into from
May 28, 2013

Conversation

mjallday
Copy link
Contributor

NOT ready to merge

  • Create framework for downloading
  • Implement download button on all pages
  • Unit tests
  • Integration tests
  • Client side validation
  • changes to CSV format
  • Link to txn on dashboard
  • Strip hyphens from transaction_id
  • amount should be formatted as $1,000.00

@mjallday
Copy link
Contributor Author

An example CSV export can be seen here (valid for the next two days only, get it while it's hot!)

This will address #11.

@timnguyen
Copy link

Looking over the example CSV export.

  1. Can we put dashboard links in? I imagine this is going to be consumed by non-engineers so I want them to be able to confirm these transactions by using the dashboard as a point of reference.
  2. updated_at provides a better starting point than created_at for figuring out what day to check bank statements to reconcile our settlements. Can we add that in? I still want created_at, but I think updated it would be useful as well.
  3. transaction_id should have the '-' stripped because (i've only seen this for HSBC and WF btw) the bank statements render them without the hyphens.
  4. I'd prefer the amounts in dollars (type::money?)
  5. People ask for fees (I know we've talked about this being difficult so maybe this is out of scope for the first iteration)
  6. Do we need holds here?

@mahmoudimus
Copy link
Contributor

+1 re: tim's suggestions (minus fees, I think fees should be under a different reporting section)

@mjallday
Copy link
Contributor Author

I agree that looking at this as a end user facing consumable rather than a dev facing item is a good way to think about this and i'll keep that in mind going forward.

  • updated_at is not a field provided by the API. this ether requires us to move CSV generation inside of the API or start exposing updated_at.
  • +1 on @mahmoudimus' suggestion of not including fees :) we could provide a CSV export of the invoices for this purpose instead?
  • holds - the way the downloads are generated is that whatever you happen to be looking at on the dashboard is what you'll receive. in this case I was looking at all transactions, if i did a search for just credits > than $100 i would have only received those in the CSV download.

everything else i'll make changes for ASAP, i've added those action items to the pull-request description, let me know if i've missed something.

@timnguyen
Copy link

@mahmoudimus @mjallday Cool. Re: fees I just brought it up because marketplaces have requested it, but I think you're right that it'll be a pain to implement and invoice reports already will allow them to match the amounts with their bank accounts.

@mjallday
Copy link
Contributor Author

@timnguyen new csv download with updates. i'm aware the dashboard link gives a 404 right now :)

@timnguyen
Copy link

@mjallday Sorry, I don't know why I forgot to mention this, but i think we should also have account_name so that we have a kind of non-techie foreign key between marketplace systems and Balanced (and the techie people can use the account_uri).

Have we gone through and decided order of columns? Otherwise, looks good.

@mjallday mjallday merged commit f8e077d into master May 28, 2013
@mjallday mjallday mentioned this pull request May 29, 2013
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants