ROLL-16 Tickets #34
Draft
ROLL-16 Tickets #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m-kus
reviewed
Aug 24, 2023
| @@ -42,6 +42,7 @@ pub struct LayeredStore<Backend: StoreBackend> { | |||
| backend: Backend, | |||
| pending_state: HashMap<String, Option<(DynStoreType, StoreTypeSer)>>, | |||
| modified_keys: HashSet<String>, | |||
| tmp_state: HashMap<String, Option<(DynStoreType, StoreTypeSer)>>, | |||
There was a problem hiding this comment.
I'd just reuse pending_state, the only difference is that for tmp values you do not update modified_keys.
You can also implement that with existing get/set methods by adding flag
m-kus
reviewed
Aug 24, 2023
| @@ -42,6 +52,11 @@ impl PureInterpreter for Dup { | |||
| } | |||
| // TODO: check if copyable | |||
There was a problem hiding this comment.
Invite you to implement this as well :)
m-kus
reviewed
Aug 24, 2023
| amount.value().into(), | ||
| )?; | ||
|
|
||
| stack.push(StackItem::Option(OptionItem::Some(Box::new(ticket.into())))) |
m-kus
reviewed
Aug 24, 2023
| identifier: &Micheline, | ||
| identifier_ty: &Type, | ||
| owner: &Address, | ||
| ) -> Result<UBig>; |
There was a problem hiding this comment.
I suggest using Nat/Int on the interface level so that if we swap the underlying big number library, we don't have to change anything here
m-kus
reviewed
Aug 24, 2023
| } | ||
|
|
||
| #[derive(Clone, Debug)] | ||
| pub struct TicketBalanceDiff { |
There was a problem hiding this comment.
Maybe reuse naming from Tezos codebase "TicketUpdate" ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.