Ensures that we don't start STA wifi when AP-only is requested. #783
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atanisoft
reviewed
Feb 10, 2024
| // Set the requested WiFi mode. | ||
| ESP_ERROR_CHECK(esp_wifi_set_mode(requested_wifi_mode)); | ||
| ESP_ERROR_CHECK(esp_wifi_set_mode(parent_->wifiMode_)); |
There was a problem hiding this comment.
Have you tested that when in AP mode that WiFi scan works? I had tested it long ago and found that it is required to use APSTA mode for scan to work this the comment in the section that was removed above.
|
That's fine, but then if you want to scan, you need to start in APSTA mode,
not in AP mode.
|
|
That breaks existing user code that expects WiFi scan to work when operating in AP mode. It's not as simple as changing the mode since that would attempt to start STA mode and rightfully crash during init. I'm fine with not creating the AP / STA interface up front but it would still be good to support scanning while in AP mode as part of a reconfiguration tool. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes codepaths that accidentally started STA mode wifi when AP-only mode was requested.