Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create plugin for Redis sink connector #291

Merged
merged 8 commits into from
Feb 16, 2023
Merged

Create plugin for Redis sink connector #291

merged 8 commits into from
Feb 16, 2023

Conversation

disrupted
Copy link
Member

Closes #288

@disrupted disrupted self-assigned this Feb 15, 2023
@MichaelKora MichaelKora requested review from MichaelKora and removed request for MichaelKora February 15, 2023 16:13
MichaelKora
MichaelKora previously approved these changes Feb 15, 2023
View reviewed changes
@disrupted disrupted marked this pull request as draft February 15, 2023 17:08
@disrupted
Copy link
Member Author

I found that when using multiple input topics, the naming is inconsistent for the sink. will have to revert it back to using the Redis host name instead of input topic name for the database sink

@disrupted disrupted marked this pull request as ready for review February 16, 2023 08:37
@disrupted disrupted merged commit 1fd9801 into main Feb 16, 2023
@disrupted disrupted deleted the feat/redis-sink branch February 16, 2023 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philipp94831 philipp94831 philipp94831 approved these changes

@MichaelKora MichaelKora Awaiting requested review from MichaelKora

@sujuka99 sujuka99 Awaiting requested review from sujuka99

Assignees

@disrupted disrupted

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Redis sink connector
3 participants
@disrupted @philipp94831 @MichaelKora