Add HostInfo to ImprovedStreamsConfig #230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raminqaf
force-pushed
the
feature/host-info
branch
from
ec0798e to
fc5784b
Compare
…-bootstrap into feature/host-info # Conflicts: # streams-bootstrap-core/src/main/java/com/bakdata/kafka/ImprovedStreamsConfig.java
…-bootstrap into feature/host-info # Conflicts: # streams-bootstrap-core/src/test/java/com/bakdata/kafka/ImprovedStreamsConfigTest.java
|
Lets merge this once #207 is merged |
raminqaf
changed the title
|
Please merge v3 branch |
…e/host-info # Conflicts: # gradle.properties # streams-bootstrap-core/src/main/java/com/bakdata/kafka/ImprovedStreamsConfig.java # streams-bootstrap-core/src/test/java/com/bakdata/kafka/ImprovedStreamsConfigTest.java
philipp94831
requested changes
Jul 23, 2024
streams-bootstrap-core/src/test/java/com/bakdata/kafka/ImprovedStreamsConfigTest.java
Outdated
Show resolved
Hide resolved
streams-bootstrap-core/src/test/java/com/bakdata/kafka/ImprovedStreamsConfigTest.java
Outdated
Show resolved
Hide resolved
streams-bootstrap-core/src/test/java/com/bakdata/kafka/ImprovedStreamsConfigTest.java
Outdated
Show resolved
Hide resolved
philipp94831
approved these changes
Jul 23, 2024
philipp94831
added a commit
that referenced
this pull request
Aug 20, 2024
Co-authored-by: Philipp Schirmer <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.