Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix naming of helm releases #216

Merged
merged 2 commits into from
May 13, 2024
Merged

Fix naming of helm releases #216

merged 2 commits into from
May 13, 2024

Conversation

philipp94831
Copy link
Member

No description provided.

@philipp94831 philipp94831 self-assigned this May 7, 2024
@philipp94831 philipp94831 marked this pull request as draft May 7, 2024 07:04
@philipp94831 philipp94831 marked this pull request as ready for review May 8, 2024 14:20
disrupted
disrupted reviewed May 13, 2024
View reviewed changes
Copy link
Member

@disrupted disrupted left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need to update any instructions for the default Helm usage (without KPOps) now that the -clean suffix isn't appended automatically anymore?

@philipp94831
Copy link
Member Author

do we need to update any instructions for the default Helm usage (without KPOps) now that the -clean suffix isn't appended automatically anymore?

I don't think so. Job will now have the name of the helm release but everything still should work

@philipp94831 philipp94831 merged commit 00a1f32 into master May 13, 2024
16 checks passed
@philipp94831 philipp94831 deleted the feature/remove-clean-suffix branch May 13, 2024 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@disrupted disrupted disrupted approved these changes

Assignees

@philipp94831 philipp94831

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@philipp94831 @disrupted