Add --application-id parameter

bakdata · Jan 26, 2024 · 615d351 · 615d351
1 parent 3d572de
commit 615d351
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 5 deletions.
diff --git a/azure-pipelines.yml b/azure-pipelines.yml
@@ -19,6 +19,7 @@ resources:
     - repository: templates
       type: github
       name: bakdata/bakdata-project-templates
+      ref: tmp/upload-snapshot
       endpoint: bot
 
 jobs:

diff --git a/charts/streams-app-cleanup-job/templates/job.yaml b/charts/streams-app-cleanup-job/templates/job.yaml
@@ -113,7 +113,7 @@ spec:
               value: "{{- range $key, $value := .Values.streams.extraInputPatterns }}{{ $key }}={{ $value }},{{- end }}"
             {{- end }}
             {{- if hasKey .Values.autoscaling "consumerGroup" }}
-            - name: "{{ .Values.configurationEnvPrefix }}_APPLICATION_ID"
+            - name: "{{ .Values.configurationEnvPrefix }}_UNIQUE_APP_ID"
               value: {{ .Values.autoscaling.consumerGroup | quote }}
             {{- end }}
             {{- range $key, $value := .Values.secrets }}

diff --git a/charts/streams-app/templates/deployment.yaml b/charts/streams-app/templates/deployment.yaml
@@ -176,7 +176,7 @@ spec:
               value: "{{- range $key, $value := .Values.streams.extraInputPatterns }}{{ $key }}={{ $value }},{{- end }}"
           {{- end }}
           {{- if hasKey .Values.autoscaling "consumerGroup" }}
-            - name: "{{ .Values.configurationEnvPrefix }}_APPLICATION_ID"
+            - name: "{{ .Values.configurationEnvPrefix }}_UNIQUE_APP_ID"
               value: {{ .Values.autoscaling.consumerGroup | quote }}
           {{- end }}
           {{- range $key, $value := .Values.secrets }}

diff --git a/streams-bootstrap/src/main/java/com/bakdata/kafka/KafkaStreamsApplication.java b/streams-bootstrap/src/main/java/com/bakdata/kafka/KafkaStreamsApplication.java
@@ -94,7 +94,7 @@ public abstract class KafkaStreamsApplication extends KafkaApplication implement
     @CommandLine.Option(names = "--volatile-group-instance-id", arity = "0..1",
             description = "Whether the group instance id is volatile, i.e., it will change on a Streams shutdown.")
     private boolean volatileGroupInstanceId;
-    @CommandLine.Option(names = "--application-id", description = "Application ID to use for Kafka Streams")
+    @CommandLine.Option(names = "--unique-app-id", description = "Application ID to use for Kafka Streams")
     private String uniqueAppId;
     private KafkaStreams streams;
     private Throwable lastException;
@@ -278,7 +278,7 @@ private String getApplicationId() {
         final String uniqueAppId = this.getUniqueAppId();
         if (uniqueAppId == null) {
             if (this.uniqueAppId == null) {
-                throw new IllegalArgumentException("Must pass --application-id or implement #getUniqueAppId()");
+                throw new IllegalArgumentException("Must pass --unique-app-id or implement #getUniqueAppId()");
             }
             return this.uniqueAppId;
         }
@@ -287,7 +287,7 @@ private String getApplicationId() {
         }
         if (!uniqueAppId.equals(this.uniqueAppId)) {
             throw new IllegalArgumentException(
-                    "Application ID provided via --application-id does not match #getUniqueAppId()");
+                    "Application ID provided via --unique-app-id does not match #getUniqueAppId()");
         }
         return uniqueAppId;
     }