-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add kpops --version
command
#200
Add kpops --version
command
#200
Conversation
@szymonsadowski3 Thanks for your contribution! It seems that your formatting is not correct, and it breaks the CI pipeline. Could you please install the pre-commit hook for the formatting? |
be99254
to
79395dc
Compare
79395dc
to
fb4e187
Compare
I just ran the pre-commit hooks and commited the changes accordingly :) |
Thanks! I created an issue for that. We need a guideline on how externals should contribute to KPOps. #201 |
kpops --version
command
fb4e187
to
cdce502
Compare
cdce502
to
bc2083d
Compare
during testing I've noticed that in local development environments reading the version dynamically from the package using
it would both times print the same version. I've switched to the poetry bumpversion plugin and now it works as expected. |
Closes #184
The ideas were taken from:
Should be integrated in conjunction with the PR that changes bump action to bump the version in the new _version.py file (will paste it below in a moment)
[edit] the related ci-templates pull request can be found here bakdata/ci-templates#95