cleanup(storage): fix MOAR IWYU warnings (googleapis#14529)

My glob expressions missed a lot of them. This pass I am fixing `std::move`, `std::string`, and `std::vector`.
bajajneha27 · Jul 22, 2024 · 2fb11b9 · 2fb11b9
1 parent a31bd17
commit 2fb11b9
Show file tree

Hide file tree

Showing 245 changed files with 431 additions and 0 deletions.
diff --git a/README.md b/README.md
@@ -29,6 +29,7 @@ of what it's like to use one of these C++ libraries.
 ```cc
 #include "google/cloud/storage/client.h"
 #include <iostream>
+#include <string>
 
 int main(int argc, char* argv[]) {
   if (argc != 2) {

diff --git a/google/cloud/storage/README.md b/google/cloud/storage/README.md
@@ -23,6 +23,7 @@ this library.
 ```cc
 #include "google/cloud/storage/client.h"
 #include <iostream>
+#include <string>
 
 int main(int argc, char* argv[]) {
   if (argc != 2) {

diff --git a/google/cloud/storage/async/bucket_name.cc b/google/cloud/storage/async/bucket_name.cc
@@ -18,6 +18,7 @@
 #include "absl/strings/match.h"
 #include "absl/strings/strip.h"
 #include <ostream>
+#include <string>
 #include <utility>
 
 namespace google {

diff --git a/google/cloud/storage/async/bucket_name_test.cc b/google/cloud/storage/async/bucket_name_test.cc
@@ -17,6 +17,7 @@
 #include <gmock/gmock.h>
 #include <sstream>
 #include <string>
+#include <utility>
 
 namespace google {
 namespace cloud {

diff --git a/google/cloud/storage/async/client.cc b/google/cloud/storage/async/client.cc
@@ -18,7 +18,9 @@
 #include "google/cloud/storage/internal/async/default_options.h"
 #include "google/cloud/storage/internal/grpc/stub.h"
 #include "google/cloud/grpc_options.h"
+#include <string>
 #include <utility>
+#include <vector>
 
 namespace google {
 namespace cloud {

diff --git a/google/cloud/storage/async/client.h b/google/cloud/storage/async/client.h
@@ -28,6 +28,9 @@
 #include "google/cloud/internal/group_options.h"
 #include "google/cloud/status_or.h"
 #include <google/storage/v2/storage.pb.h>
+#include <string>
+#include <utility>
+#include <vector>
 
 namespace google {
 namespace cloud {

diff --git a/google/cloud/storage/async/client_test.cc b/google/cloud/storage/async/client_test.cc
@@ -22,6 +22,7 @@
 #include <google/protobuf/text_format.h>
 #include <gmock/gmock.h>
 #include <string>
+#include <utility>
 
 namespace google {
 namespace cloud {

diff --git a/google/cloud/storage/async/object_responses.h b/google/cloud/storage/async/object_responses.h
@@ -26,6 +26,7 @@
 #include <cstdint>
 #include <map>
 #include <string>
+#include <utility>
 #include <vector>
 
 namespace google {

diff --git a/google/cloud/storage/async/reader_test.cc b/google/cloud/storage/async/reader_test.cc
@@ -18,6 +18,7 @@
 #include "google/cloud/testing_util/async_sequencer.h"
 #include "google/cloud/testing_util/status_matchers.h"
 #include <gmock/gmock.h>
+#include <utility>
 
 namespace google {
 namespace cloud {

diff --git a/google/cloud/storage/async/rewriter_test.cc b/google/cloud/storage/async/rewriter_test.cc
@@ -17,6 +17,7 @@
 #include "google/cloud/storage/testing/canonical_errors.h"
 #include "google/cloud/testing_util/status_matchers.h"
 #include <gmock/gmock.h>
+#include <utility>
 
 namespace google {
 namespace cloud {

diff --git a/google/cloud/storage/async/token_test.cc b/google/cloud/storage/async/token_test.cc
@@ -15,6 +15,7 @@
 #include "google/cloud/storage/async/token.h"
 #include <gmock/gmock.h>
 #include <type_traits>
+#include <utility>
 
 namespace google {
 namespace cloud {

diff --git a/google/cloud/storage/async/write_payload.h b/google/cloud/storage/async/write_payload.h
@@ -21,6 +21,7 @@
 #include "absl/strings/cord.h"
 #include <cstdint>
 #include <string>
+#include <utility>
 #include <vector>
 
 namespace google {

diff --git a/google/cloud/storage/async/writer.h b/google/cloud/storage/async/writer.h
@@ -24,6 +24,7 @@
 #include "absl/types/variant.h"
 #include <google/storage/v2/storage.pb.h>
 #include <memory>
+#include <string>
 #include <utility>
 
 namespace google {

diff --git a/google/cloud/storage/async/writer_test.cc b/google/cloud/storage/async/writer_test.cc
@@ -17,6 +17,8 @@
 #include "google/cloud/storage/testing/canonical_errors.h"
 #include "google/cloud/testing_util/status_matchers.h"
 #include <gmock/gmock.h>
+#include <string>
+#include <utility>
 
 namespace google {
 namespace cloud {

diff --git a/google/cloud/storage/benchmarks/aggregate_download_throughput_benchmark.cc b/google/cloud/storage/benchmarks/aggregate_download_throughput_benchmark.cc
@@ -31,7 +31,9 @@
 #include <iomanip>
 #include <random>
 #include <sstream>
+#include <string>
 #include <thread>
+#include <utility>
 #include <vector>
 
 namespace {

diff --git a/google/cloud/storage/benchmarks/aggregate_download_throughput_options.cc b/google/cloud/storage/benchmarks/aggregate_download_throughput_options.cc
@@ -18,7 +18,9 @@
 #include "google/cloud/internal/make_status.h"
 #include <iterator>
 #include <sstream>
+#include <string>
 #include <utility>
+#include <vector>
 
 namespace google {
 namespace cloud {

diff --git a/google/cloud/storage/benchmarks/aggregate_upload_throughput_options.cc b/google/cloud/storage/benchmarks/aggregate_upload_throughput_options.cc
@@ -17,7 +17,9 @@
 #include "google/cloud/internal/absl_str_join_quiet.h"
 #include <iterator>
 #include <sstream>
+#include <string>
 #include <utility>
+#include <vector>
 
 namespace google {
 namespace cloud {

diff --git a/google/cloud/storage/benchmarks/benchmark_make_random_test.cc b/google/cloud/storage/benchmarks/benchmark_make_random_test.cc
@@ -14,6 +14,7 @@
 
 #include "google/cloud/storage/benchmarks/benchmark_utils.h"
 #include <gmock/gmock.h>
+#include <string>
 
 namespace google {
 namespace cloud {

diff --git a/google/cloud/storage/benchmarks/benchmark_utils.cc b/google/cloud/storage/benchmarks/benchmark_utils.cc
@@ -29,6 +29,9 @@
 #include "absl/time/time.h"
 #include <future>
 #include <sstream>
+#include <string>
+#include <utility>
+#include <vector>
 
 namespace google {
 namespace cloud {

diff --git a/google/cloud/storage/benchmarks/benchmark_utils.h b/google/cloud/storage/benchmarks/benchmark_utils.h
@@ -28,6 +28,7 @@
 #include <iostream>
 #include <sstream>
 #include <string>
+#include <utility>
 
 namespace google {
 namespace cloud {

diff --git a/google/cloud/storage/benchmarks/bounded_queue.h b/google/cloud/storage/benchmarks/bounded_queue.h
@@ -19,6 +19,7 @@
 #include <condition_variable>
 #include <deque>
 #include <mutex>
+#include <utility>
 
 namespace google {
 namespace cloud {

diff --git a/google/cloud/storage/benchmarks/create_dataset_options.cc b/google/cloud/storage/benchmarks/create_dataset_options.cc
@@ -15,7 +15,9 @@
 #include "google/cloud/storage/benchmarks/create_dataset_options.h"
 #include "google/cloud/internal/make_status.h"
 #include <sstream>
+#include <string>
 #include <utility>
+#include <vector>
 
 namespace google {
 namespace cloud {

diff --git a/google/cloud/storage/benchmarks/storage_file_transfer_benchmark.cc b/google/cloud/storage/benchmarks/storage_file_transfer_benchmark.cc
@@ -24,7 +24,9 @@
 #include <future>
 #include <iomanip>
 #include <sstream>
+#include <string>
 #include <utility>
+#include <vector>
 
 namespace {
 namespace gcs = ::google::cloud::storage;

diff --git a/google/cloud/storage/benchmarks/storage_parallel_uploads_benchmark.cc b/google/cloud/storage/benchmarks/storage_parallel_uploads_benchmark.cc
@@ -25,7 +25,9 @@
 #include <future>
 #include <iomanip>
 #include <sstream>
+#include <string>
 #include <utility>
+#include <vector>
 
 namespace {
 namespace gcs = ::google::cloud::storage;

diff --git a/google/cloud/storage/benchmarks/storage_throughput_vs_cpu_benchmark.cc b/google/cloud/storage/benchmarks/storage_throughput_vs_cpu_benchmark.cc
@@ -29,6 +29,9 @@
 #include <future>
 #include <set>
 #include <sstream>
+#include <string>
+#include <utility>
+#include <vector>
 
 namespace {
 namespace gcs = ::google::cloud::storage;

diff --git a/google/cloud/storage/benchmarks/throughput_experiment.cc b/google/cloud/storage/benchmarks/throughput_experiment.cc
@@ -20,6 +20,8 @@
 #include "google/cloud/storage/internal/grpc/ctype_cord_workaround.h"
 #include "google/cloud/grpc_error_delegate.h"
 #include <google/storage/v2/storage.grpc.pb.h>
+#include <string>
+#include <utility>
 #endif  // GOOGLE_CLOUD_CPP_STORAGE_HAVE_GRPC
 #include <curl/curl.h>
 #include <iterator>

diff --git a/google/cloud/storage/benchmarks/throughput_experiment_test.cc b/google/cloud/storage/benchmarks/throughput_experiment_test.cc
@@ -17,6 +17,8 @@
 #include "google/cloud/internal/getenv.h"
 #include "google/cloud/testing_util/status_matchers.h"
 #include <gmock/gmock.h>
+#include <string>
+#include <utility>
 
 namespace google {
 namespace cloud {

diff --git a/google/cloud/storage/benchmarks/throughput_options.cc b/google/cloud/storage/benchmarks/throughput_options.cc
@@ -20,6 +20,9 @@
 #include "absl/strings/str_split.h"
 #include "absl/time/time.h"
 #include <sstream>
+#include <string>
+#include <utility>
+#include <vector>
 
 namespace google {
 namespace cloud {

diff --git a/google/cloud/storage/benchmarks/throughput_result.h b/google/cloud/storage/benchmarks/throughput_result.h
@@ -18,6 +18,7 @@
 #include "google/cloud/storage/benchmarks/benchmark_utils.h"
 #include <chrono>
 #include <cstdint>
+#include <string>
 
 namespace google {
 namespace cloud {

diff --git a/google/cloud/storage/benchmarks/throughput_result_test.cc b/google/cloud/storage/benchmarks/throughput_result_test.cc
@@ -20,6 +20,8 @@
 #include "absl/strings/match.h"
 #include <gmock/gmock.h>
 #include <algorithm>
+#include <string>
+#include <utility>
 
 namespace google {
 namespace cloud {

diff --git a/google/cloud/storage/examples/storage_async_mock_samples.cc b/google/cloud/storage/examples/storage_async_mock_samples.cc
@@ -18,6 +18,7 @@
 #include <gmock/gmock.h>
 #include <iostream>
 #include <string>
+#include <utility>
 
 namespace {
 

diff --git a/google/cloud/storage/examples/storage_async_samples.cc b/google/cloud/storage/examples/storage_async_samples.cc
@@ -29,6 +29,7 @@
 #include <map>
 #include <random>
 #include <string>
+#include <utility>
 #include <vector>
 
 namespace {

diff --git a/google/cloud/storage/examples/storage_bucket_acl_samples.cc b/google/cloud/storage/examples/storage_bucket_acl_samples.cc
@@ -17,7 +17,10 @@
 #include "google/cloud/internal/getenv.h"
 #include <functional>
 #include <iostream>
+#include <string>
 #include <thread>
+#include <utility>
+#include <vector>
 
 namespace {
 

diff --git a/google/cloud/storage/examples/storage_bucket_autoclass_samples.cc b/google/cloud/storage/examples/storage_bucket_autoclass_samples.cc
@@ -17,7 +17,10 @@
 #include "google/cloud/internal/getenv.h"
 #include <functional>
 #include <iostream>
+#include <string>
 #include <thread>
+#include <utility>
+#include <vector>
 
 namespace {
 

diff --git a/google/cloud/storage/examples/storage_bucket_cors_samples.cc b/google/cloud/storage/examples/storage_bucket_cors_samples.cc
@@ -17,7 +17,10 @@
 #include "google/cloud/internal/getenv.h"
 #include <functional>
 #include <iostream>
+#include <string>
 #include <thread>
+#include <utility>
+#include <vector>
 
 namespace {
 

diff --git a/google/cloud/storage/examples/storage_bucket_default_kms_key_samples.cc b/google/cloud/storage/examples/storage_bucket_default_kms_key_samples.cc
@@ -17,7 +17,10 @@
 #include "google/cloud/internal/getenv.h"
 #include <functional>
 #include <iostream>
+#include <string>
 #include <thread>
+#include <utility>
+#include <vector>
 
 namespace {
 

diff --git a/google/cloud/storage/examples/storage_bucket_iam_samples.cc b/google/cloud/storage/examples/storage_bucket_iam_samples.cc
@@ -16,7 +16,10 @@
 #include "google/cloud/storage/examples/storage_examples_common.h"
 #include "google/cloud/internal/getenv.h"
 #include <iostream>
+#include <string>
 #include <thread>
+#include <utility>
+#include <vector>
 
 namespace {
 

diff --git a/google/cloud/storage/examples/storage_bucket_object_retention_samples.cc b/google/cloud/storage/examples/storage_bucket_object_retention_samples.cc
@@ -17,7 +17,10 @@
 #include "google/cloud/internal/getenv.h"
 #include <functional>
 #include <iostream>
+#include <string>
 #include <thread>
+#include <utility>
+#include <vector>
 
 namespace {
 

diff --git a/google/cloud/storage/examples/storage_bucket_requester_pays_samples.cc b/google/cloud/storage/examples/storage_bucket_requester_pays_samples.cc
@@ -17,7 +17,10 @@
 #include "google/cloud/internal/getenv.h"
 #include <functional>
 #include <iostream>
+#include <string>
 #include <thread>
+#include <utility>
+#include <vector>
 
 namespace {
 

diff --git a/google/cloud/storage/examples/storage_bucket_samples.cc b/google/cloud/storage/examples/storage_bucket_samples.cc
@@ -17,6 +17,9 @@
 #include "google/cloud/internal/getenv.h"
 #include <functional>
 #include <iostream>
+#include <string>
+#include <utility>
+#include <vector>
 
 namespace {
 

diff --git a/google/cloud/storage/examples/storage_bucket_soft_delete_samples.cc b/google/cloud/storage/examples/storage_bucket_soft_delete_samples.cc
@@ -17,7 +17,10 @@
 #include "google/cloud/internal/getenv.h"
 #include <functional>
 #include <iostream>
+#include <string>
 #include <thread>
+#include <utility>
+#include <vector>
 
 namespace {
 

diff --git a/google/cloud/storage/examples/storage_client_initialization_samples.cc b/google/cloud/storage/examples/storage_client_initialization_samples.cc
@@ -21,6 +21,8 @@
 #include <iostream>
 #include <string>
 #include <thread>
+#include <utility>
+#include <vector>
 
 namespace {
 

diff --git a/google/cloud/storage/examples/storage_client_mock_samples.cc b/google/cloud/storage/examples/storage_client_mock_samples.cc
@@ -18,6 +18,7 @@
 #include <gmock/gmock.h>
 #include <iostream>
 #include <string>
+#include <utility>
 
 namespace {