Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cuda9 #117

Closed
wants to merge 2 commits into from
Closed

Fix cuda9 #117

wants to merge 2 commits into from

Conversation

dzhwinter
Copy link
Collaborator

@dzhwinter dzhwinter commented Apr 27, 2018

the default version didn't generate available binary on Volta arch GPU, this PR fix the cuda9 error.

@@ -40,6 +40,13 @@ IF (CUDA_VERSION GREATER 7.6)
set(CUDA_NVCC_FLAGS "${CUDA_NVCC_FLAGS} -gencode arch=compute_62,code=sm_62")
ENDIF()

IF ((CUDA_VERSION GREATER 9.0) OR (CUDA_VERSION EQUAL 9.0))
set(CUDA_NVCC_FLAGS "${CUDA_NVCC_FLAGS} -gencode arch=compute_60,code=sm_60")

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like the above if-block already enabled CUDA code generation for sm60, sm61, and sm62. Could we remove these three lines from this if-block?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, done.

@dzhwinter
Copy link
Collaborator Author

close this PR, this one has been cherry-picked into #118

@dzhwinter dzhwinter closed this Apr 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants