Use same options in proto compile and load #90
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First of all, thank you for this example repository! I've been using it as a reference countless times while writing TypeScript services.
I've noticed a small footgun in
proto-loader
example:When using the flags
--oneofs
for thebuild:proto
step, the generated code provides a virtual property for eachoneof
message type.However, if the same option is not used in
loadSync
method, the virtual property is always undefined.I've added the options to match those used in the
build:proto
, so people in the future will avoid the same mistake.