Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Event badging form setup #84

Closed
wants to merge 15 commits into from

Conversation

Kingscliq
Copy link

@Kingscliq Kingscliq commented Feb 17, 2024

This issue is not a fix but a setup for issue #82, the following were added to the event badging project

  1. Set up the page for event badging forms
  2. Built out the TextField Component which is also reusable
  3. Conditionally rendered the pages for the virtual and physical pages

@Ruth-ikegah cc: @kaxada

@kaxada
Copy link
Contributor

kaxada commented Feb 21, 2024

@Kingscliq always reference the issue you are fixing somewhere in the commits or the comment section here so that reviewers don't confuse implementations.

@Kingscliq
Copy link
Author

@Kingscliq always reference the issue you are fixing somewhere in the commits or the comment section here so that reviewers don't confuse implementations.

Hi @kaxada thanks for the feedback, how do I reference the issues, is there a template for that at the moment that I can look through

@Ruth-ikegah
Copy link
Contributor

@Kingscliq always reference the issue you are fixing somewhere in the commits or the comment section here so that reviewers don't confuse implementations.

Hi @kaxada thanks for the feedback, how do I reference the issues, is there a template for that at the moment that I can look through

@Kingscliq always reference the issue you are fixing somewhere in the commits or the comment section here so that reviewers don't confuse implementations.

Hi @kaxada thanks for the feedback, how do I reference the issues, is there a template for that at the moment that I can look through

Hi @Kingscliq you use the description, "This issue fixes #issuenumber". We hope to create a template soon.

@Kingscliq
Copy link
Author

@Kingscliq always reference the issue you are fixing somewhere in the commits or the comment section here so that reviewers don't confuse implementations.

Hi @kaxada thanks for the feedback, how do I reference the issues, is there a template for that at the moment that I can look through

@Kingscliq always reference the issue you are fixing somewhere in the commits or the comment section here so that reviewers don't confuse implementations.

Hi @kaxada thanks for the feedback, how do I reference the issues, is there a template for that at the moment that I can look through

Hi @Kingscliq you use the description, "This issue fixes #issuenumber". We hope to create a template soon.

Oh thanks for the feedback @Ruth-ikegah will do just that

@kaxada kaxada force-pushed the kingscliq-event-badging-form branch from 13beaa6 to 1769cbc Compare February 25, 2024 18:26
Copy link
Contributor

@kaxada kaxada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Kingscliq did you intend to have it look this way or it is still a work in progress?
image

@Kingscliq
Copy link
Author

@Kingscliq did you intend to have it look this way or it is still a work in progress? image

@kaxada It's a work in progress, working alongside @IsraelChidera on this issue

@kaxada kaxada marked this pull request as draft February 25, 2024 19:48
@Ruth-ikegah
Copy link
Contributor

Hi @Kingscliq great work so far on this PR. However, a little challenge because another developer is currently assigned to #82 and has been working on it. I am so sorry about this. Usually the flow is before you take up an issue, you should check if it has assigned and if not you can ask to be assigned to it.

Could you work on #89 or any other issues here not assigned to anyone?

I am sorry once again for the confusion. Let me know if you have any questions.

@Kingscliq
Copy link
Author

Kingscliq commented Feb 26, 2024

Hi @Kingscliq great work so far on this PR. However, a little challenge because another developer is currently assigned to #82 and has been working on it. I am so sorry about this. Usually the flow is before you take up an issue, you should check if it has assigned and if not you can ask to be assigned to it.

Could you work on #89 or any other issues here not assigned to anyone?

I am sorry once again for the confusion. Let me know if you have any questions.

Hi @Ruth-ikegah thanks for the clarity, is the developer you were speaking @IsraelChidera ? If it is, then we were working alongside on the issue, but if not, then it was a mistake from me.

But no problem, I will start working on #89, I will tag you on it so I can be assigned

@Ruth-ikegah
Copy link
Contributor

Hi @Kingscliq great work so far on this PR. However, a little challenge because another developer is currently assigned to #82 and has been working on it. I am so sorry about this. Usually the flow is before you take up an issue, you should check if it has assigned and if not you can ask to be assigned to it.
Could you work on #89 or any other issues here not assigned to anyone?
I am sorry once again for the confusion. Let me know if you have any questions.

Hi @Ruth-ikegah thanks for the clarity, is the developer you were speaking @IsraelChidera ? If it is, then we were working alongside on the issue, but if not, then it was a mistake from me.

But no problem, I will start working on #89, I will tag you on it so I can be assigned

Thanks for understanding @Kingscliq ! No the person is Mide. If you check the assigned section on #82. So sorry for the confusion too Chidera! @IsraelChidera you can pick other open issues too that are not assigned. I will go ahead to close this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants