Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code refactor to prepare for adding support for multiple providers #3

Merged
merged 5 commits into from
Nov 23, 2023

Conversation

zillemarco
Copy link
Contributor

This PR depends on #1 and refactors some of the code in order to prepare for adding support for multiple repository providers, like GitLab.

@zillemarco zillemarco force-pushed the zillemarco-provider-refactor branch from 1660a5c to aee9032 Compare November 8, 2023 16:43
@zillemarco zillemarco marked this pull request as ready for review November 8, 2023 17:08
Copy link
Contributor

@sgoggins sgoggins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I am going to tag @kaxada to check this out as well just to make sure we are clear with regards to the implementation side before I merge it.

@zillemarco
Copy link
Contributor Author

Thank you @sgoggins, that's perfect 🙂

@kaxada kaxada merged commit 4ca12e3 into badging:main Nov 23, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants