Associate VolumeSnapshots with SnapshotSchedules via OwnerReferences

[salmon111]

Describe what this PR does
This PR addresses #359 by adding OwnerReferences to VolumeSnapshot objects created by SnapshotSchedule.
This ensures that VolumeSnapshots are automatically tracked and cleaned up when their parent SnapshotSchedule is deleted.
The addition improves resource management and simplifies dependency handling.

Is there anything that requires special attention?
This feature can be enabled by setting enableOwnerReferences to true in values.yaml.
The default behavior remains unchanged even after the update.

Related issues:

• Add metadata.ownerReferences to all created VolumeSnapshots #359

[salmon111]

Hi @JohnStrunk,
Would you mind taking a look at this PR when you have some time?
Let me know if there's anything you'd like me to address or clarify. Thanks!

[JohnStrunk]

Thank you for taking the initiative to put something together.
I do plan to take a look. I'm a bit backed up w/ other items atm. I'm hoping to get to it this week.

[salmon111]

Thank you for letting me know! I completely understand you're busy.
Please take your time, and let me know if there's anything I can do to make the review easier. I appreciate it!

[salmon111]

I’ve currently set this up to pass values via command arguments, but I’m thinking of refactoring this to use a ConfigMap instead.
The main reason is that ConfigMaps would allow more flexibility in managing configurations, especially when changes are needed dynamically.

I’d appreciate your feedback on whether this change would align better with best practices or if the current implementation is sufficient.

[JohnStrunk]

I'd prefer to keep it as-is. Since we don't have a CM currently, I'd rather not add one.

[codecov]

Codecov Report

Attention: Patch coverage is 75.00000% with 5 lines in your changes missing coverage. Please review.

Project coverage is 55.0%. Comparing base (e02dec0) to head (b2697a1).
Report is 5 commits behind head on master.

Files with missing lines	Patch %	Lines
internal/controller/snapshotschedule_controller.go	75.0%	5 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff            @@
##           master    #697     +/-   ##
========================================
+ Coverage    53.3%   55.0%   +1.7%     
========================================
  Files           2       2             
  Lines         313     325     +12     
========================================
+ Hits          167     179     +12     
  Misses        139     139             
  Partials        7       7             

Files with missing lines	Coverage Δ
internal/controller/snapshotschedule_controller.go	41.9% <75.0%> (+3.4%)	⬆️

[JohnStrunk]

This is a nicely done patch. Thank you!
It just needs the formatting on the README fixed, then it's good to go.

[JohnStrunk]

Looks like a line-length issue from the lint/pre-commit job:

helm/snapscheduler/README.md:160: MD013 Line length

[salmon111]

@JohnStrunk
Thank you for the feedback and kind words!
I’ve fixed the formatting on the README as suggested.
Please let me know if there’s anything else that needs adjustment.
Looking forward to your approval!

[mergify]

This pull request has been removed from the queue for the following reason: pull request branch update failed.

The pull request can't be updated

You should look at the reason for the failure and decide if the pull request needs to be fixed or if you want to requeue it.

If you want to requeue this pull request, you need to post a comment with the text: @mergifyio requeue