Remove check of throwable type in uncaughtException handler #111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BartoszLitwiniuk
changed the title
BartoszLitwiniuk
changed the title
konraddysput
approved these changes
Dec 12, 2023
backtrace-library/src/main/java/backtraceio/library/base/BacktraceBase.java
Show resolved
Hide resolved
backtrace-library/src/main/java/backtraceio/library/models/BacktraceExceptionHandler.java
Outdated
Show resolved
Hide resolved
backtrace-library/src/main/java/backtraceio/library/models/BacktraceExceptionHandler.java
Show resolved
Hide resolved
konraddysput
approved these changes
Jan 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request addresses a specific issue related to the uncaughtException handler. Currently, the code checks if the throwable object is of type Exception. However, this prevents the registration of errors such as OutOfMemoryError, which do not extend from the Exception class.
In this pull request, I am proposing the removal of the check for the specific type Exception to ensure that errors like OutOfMemoryError are appropriately captured and handled.
Please review the changes at your earliest convenience. I believe this modification will improve the robustness of our error handling mechanism. This pull requests contains also unit tests for both cases: exception and error.