Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(kiali) add kiali-frontend #2223

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

aljesusg
Copy link
Contributor

Hey, I just made a Pull Request!

Add kiali frontendn
Screenshot From 2024-12-20 12-32-31
Screenshot From 2024-12-20 12-32-09
Screenshot From 2024-12-20 12-31-55
Screenshot From 2024-12-20 12-31-41

Close #1151

✔️ Checklist

  • A changeset describing the change and affected packages. (more info)
  • Added or updated documentation
  • Screenshots attached (for UI changes)
  • All your commits have a Signed-off-by line in the message. (more info)

@aljesusg aljesusg requested a review from a team as a code owner December 20, 2024 12:09
@aljesusg aljesusg requested a review from awanlin December 20, 2024 12:09
@backstage-goalie
Copy link
Contributor

backstage-goalie bot commented Dec 20, 2024

Changed Packages

Package Name Package Path Changeset Bump Current Version
app workspaces/kiali/packages/app none v0.0.0
backend workspaces/kiali/packages/backend none v0.0.0
@backstage-community/plugin-kiali-backend workspaces/kiali/plugins/kiali-backend patch v1.19.3
@backstage-community/plugin-kiali workspaces/kiali/plugins/kiali patch v1.35.0

@aljesusg
Copy link
Contributor Author

cc @nickboldt

@backstage-goalie
Copy link
Contributor

Thanks for the contribution!
All commits need to be DCO signed before they are reviewed. Please refer to the the DCO section in CONTRIBUTING.md or the DCO status for more info.

@awanlin awanlin requested review from nickboldt and BethGriggs and removed request for awanlin December 20, 2024 13:31
@awanlin
Copy link
Contributor

awanlin commented Dec 20, 2024

HI @BethGriggs and @nickboldt, can you review this? Sorry to punt on this one but it's pretty massive and I think one of you will have more context and be able to get through the noise a lot easier than me. Thanks!

@aljesusg aljesusg force-pushed the kiali branch 6 times, most recently from 7614357 to d788763 Compare December 20, 2024 19:53
@aljesusg
Copy link
Contributor Author

Hi, no way to fix this

aljesusg@thinkpadp1gen3:~/Projects/backstage/community-plugins/workspaces/kiali (kiali)$ yarn run backstage-cli repo fix
aljesusg@thinkpadp1gen3:~/Projects/backstage/community-plugins/workspaces/kiali (kiali)$ yarn run backstage-cli repo fix --check --publish
The following packages are out of sync, run 'yarn fix' to fix them:
  app
  backend
  @backstage-community/plugin-kiali-backend

What I am missing?

@awanlin
Copy link
Contributor

awanlin commented Dec 20, 2024

It's not super obvious but can you try this: yarn run backstage-cli repo fix --publish

@aljesusg
Copy link
Contributor Author

It's not super obvious but can you try this: yarn run backstage-cli repo fix --publish

Thanks ! Totally not obvious, I launched it with --check

Signed-off-by: Alberto Gutierrez <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🔌 Plugin: Kiali
3 participants