Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(explore): remove support for old backend system #2212

Merged

Conversation

secustor
Copy link
Member

Hey, I just made a Pull Request!

This PR removes support for the old Backend system and removes the dependency to @backstage/backend-common

✔️ Checklist

  • A changeset describing the change and affected packages. (more info)
  • Added or updated documentation
  • Tests for new functionality and regression tests for bug fixes
  • Screenshots attached (for UI changes)
  • All your commits have a Signed-off-by line in the message. (more info)

@secustor secustor requested review from a team as code owners December 19, 2024 11:27
@secustor secustor requested a review from vinzscam December 19, 2024 11:27
@backstage-goalie
Copy link
Contributor

backstage-goalie bot commented Dec 19, 2024

Changed Packages

Package Name Package Path Changeset Bump Current Version
@backstage-community/plugin-explore-backend workspaces/explore/plugins/explore-backend minor v0.2.0

Copy link
Contributor

@awanlin awanlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @secustor, thanks for this, just commenting around timing to start.

Copy link
Contributor

github-actions bot commented Jan 2, 2025

This PR has been automatically marked as stale because it has not had recent activity from the author. It will be closed if no further activity occurs. If the PR was closed and you want it re-opened, let us know and we'll re-open the PR so that you can continue the contribution!

@github-actions github-actions bot added the stale label Jan 2, 2025
@awanlin awanlin removed the stale label Jan 2, 2025
Copy link
Contributor

@awanlin awanlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright, let's move this forward @secustor, if you can resolve the conflict then we should be able to merge this in 👍

Signed-off-by: secustor <[email protected]>
Signed-off-by: secustor <[email protected]>
@secustor secustor requested a review from awanlin January 3, 2025 09:24
Copy link
Contributor

@awanlin awanlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again @secustor 🚀

@awanlin awanlin merged commit 088f904 into backstage:main Jan 3, 2025
12 checks passed
@secustor secustor deleted the feat/explore-remove-old-backend-system branch January 3, 2025 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants