Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: division by zero in language stats #2171

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Zarthus
Copy link

@Zarthus Zarthus commented Dec 11, 2024

Should fix #2160 (have not tested this particular change as I did not have a matching data set to reproduce)

  • A changeset describing the change and affected packages. (more info)
  • Added or updated documentation
  • Tests for new functionality and regression tests for bug fixes
  • Screenshots attached (for UI changes)
  • All your commits have a Signed-off-by line in the message. (more info)

@Zarthus Zarthus requested a review from a team as a code owner December 11, 2024 12:33
@Zarthus Zarthus requested a review from vinzscam December 11, 2024 12:33
@backstage-goalie
Copy link
Contributor

backstage-goalie bot commented Dec 11, 2024

Changed Packages

Package Name Package Path Changeset Bump Current Version
@backstage-community/plugin-copilot workspaces/copilot/plugins/copilot patch v0.3.0

@Zarthus Zarthus force-pushed the fix-division-by-zero-2160 branch from 361a556 to aa8a8c8 Compare December 11, 2024 12:48
@vinzscam
Copy link
Member

@yoramshai any chance you could see whether these changes fix your issue?
cc @esw-afabiano

Co-authored-by: Vincenzo Scamporlino <[email protected]>
Signed-off-by: Jos Ahrens <[email protected]>
@yoramshai
Copy link

@vinzscam will try and update

@awanlin awanlin requested a review from vinzscam December 17, 2024 15:54
@yoramshai
Copy link

@vinzscam It doesn't look like the issue has been completely solved after updating the above package.

@Zarthus
Copy link
Author

Zarthus commented Dec 24, 2024

@yoramshai 'completely'? does that mean you are experiencing partially improved behaviour or that it still gives the same issue as in the bug report?

@yoramshai
Copy link

yoramshai commented Dec 24, 2024

What I'm seeing is one of the lang has too high percentage (e.g. > 500%)
Also I found out that I'm able to reproduce the infinity when I'm playing around with the dates (didn't find any pattern yet)
image

@Zarthus
Copy link
Author

Zarthus commented Dec 24, 2024

I'll check back once I'm back at work so I have a proper dataset to work with (would be new years), but yeah - that can't be intended. It'd be interesting to know what the GitHub API's response is to that Dockerfile analysis but I imagine I'd be able to figure out a reproduction case once I sit down with the project proper.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 Copilot: Infinity Acceptance Rate
3 participants