Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update codeowners for the 3scale plugin #1540

Merged
merged 1 commit into from
Nov 5, 2024

Conversation

04kash
Copy link
Member

@04kash 04kash commented Oct 17, 2024

Hey, I just made a Pull Request!

Added @04kash and @AndrienkoAleksandr as code owners for the 3scale plugin.

✔️ Checklist

  • A changeset describing the change and affected packages. (more info)
  • Added or updated documentation
  • Tests for new functionality and regression tests for bug fixes
  • Screenshots attached (for UI changes)
  • All your commits have a Signed-off-by line in the message. (more info)

@04kash 04kash requested a review from a team as a code owner October 17, 2024 16:55
@04kash 04kash requested a review from vinzscam October 17, 2024 16:55
@04kash
Copy link
Member Author

04kash commented Oct 17, 2024

@AndrienkoAleksandr could you raise an issue to become an Organization Member?

@04kash
Copy link
Member Author

04kash commented Oct 29, 2024

@vinzscam based on this comment: backstage/community#166 (comment), I think this PR is good to merge

@04kash 04kash force-pushed the update-3scale-codeowners branch from b1e46cb to cbaa34c Compare October 29, 2024 15:15
Copy link
Member

@christoph-jerolimov christoph-jerolimov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

@nickboldt nickboldt merged commit ed8eaba into backstage:main Nov 5, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants