feat(tech-insights): allow usage of API client from backend plugins (#…

…630)

* feat(tech-insights): move client into separate package and allow using backend auth

Signed-off-by: secustor <[email protected]>

* feat(tech-insights): move client into common package under /client export

Signed-off-by: secustor <[email protected]>

* feat(tech-insights): run yarn fix

Signed-off-by: secustor <[email protected]>

* remove backend from changeset

Signed-off-by: secustor <[email protected]>

* update api report

Signed-off-by: secustor <[email protected]>

* add client api report

Signed-off-by: secustor <[email protected]>

* add missing documentation and try to solve api report problem

Signed-off-by: secustor <[email protected]>

* pin version

Signed-off-by: secustor <[email protected]>

* dedupe lock file

Signed-off-by: secustor <[email protected]>

* Apply suggestions from code review

Co-authored-by: Jussi Hallila <[email protected]>
Signed-off-by: Sebastian Poxhofer <[email protected]>

---------

Signed-off-by: secustor <[email protected]>
Signed-off-by: Sebastian Poxhofer <[email protected]>
Co-authored-by: Jussi Hallila <[email protected]>

.github/workflows/ci.yml

@@ -28,7 +28,7 @@ jobs:
         uses: actions/checkout@1d96c772d19495a3b5c517cd2bc0cb401ea0529f # v4
         with:
           # Needed for diff
-          fetch-depth: ${{ env.NUMBER_OF_COMMITS }}
+          fetch-depth: 100
 
       - name: Set up Node
         uses: actions/setup-node@60edb5dd545a775178f52524783378180af0d1f8 # v4

.github/workflows/release_workspace.yml

@@ -74,7 +74,8 @@ jobs:
         run: yarn install --immutable
 
       - name: Fetch previous commit for release check
-        run: git fetch origin '${{ github.event.before }}'
+        if: ${{ github.event.before != '' }}
+        run: git fetch origin '${{ github.event.before }}
 
       - name: Fetch the commit that triggered the workflow (used by backstage/changesets-action)
         run: git fetch origin ${{ github.sha }}
@@ -83,8 +84,14 @@ jobs:
       - name: Check if release
         id: release_check
         if: inputs.force_release != true
-        run: node ../../scripts/ci/check-if-release.js
+        run: |
+          COMMIT_SHA_BEFORE=${{ github.event.before }}
+          if [ -z "$COMMIT_SHA_BEFORE" ]; then
+            COMMIT_SHA_BEFORE=$(git rev-list --max-parents=0 HEAD)
+          fi
+          node ../../scripts/ci/check-if-release.js
         env:
+          TARGET_BRANCH: ${{ inputs.branch }}
           WORKSPACE_NAME: ${{ inputs.workspace }}
           COMMIT_SHA_BEFORE: '${{ github.event.before }}'
 

workspaces/scaffolder-relation-processor/plugins/catalog-backend-module-scaffolder-relation-processor/package.json

@@ -1,7 +1,7 @@
 {
   "name": "@backstage-community/plugin-catalog-backend-module-scaffolder-relation-processor",
   "description": "The scaffolder-relation-processor backend module for the catalog plugin.",
-  "version": "1.2.8",
+  "version": "1.0.0",
   "main": "src/index.ts",
   "types": "src/index.ts",
   "license": "Apache-2.0",

workspaces/tech-insights/.changeset/selfish-bats-pretend.md

@@ -0,0 +1,6 @@
+---
+'@backstage-community/plugin-tech-insights-common': patch
+'@backstage-community/plugin-tech-insights': patch
+---
+
+Move client to common package and allow to use backend auth system

workspaces/tech-insights/plugins/tech-insights-common/api-report-client.md

@@ -0,0 +1,53 @@
+## API Report File for "@backstage-community/plugin-tech-insights-common"
+
+> Do not edit this file. It is a report generated by [API Extractor](https://api-extractor.com/).
+
+```ts
+import { AuthService } from '@backstage/backend-plugin-api';
+import { BulkCheckResponse } from '@backstage-community/plugin-tech-insights-common';
+import { CheckResult } from '@backstage-community/plugin-tech-insights-common';
+import { CompoundEntityRef } from '@backstage/catalog-model';
+import { DiscoveryApi } from '@backstage/core-plugin-api';
+import { FactSchema } from '@backstage-community/plugin-tech-insights-common';
+import { IdentityApi } from '@backstage/core-plugin-api';
+import { JsonValue } from '@backstage/types';
+
+// @public
+export type Check = {
+  id: string;
+  type: string;
+  name: string;
+  description: string;
+  factIds: string[];
+  successMetadata?: Record<string, unknown>;
+  failureMetadata?: Record<string, unknown>;
+};
+
+// @public
+export interface InsightFacts {
+  [factId: string]: {
+    timestamp: string;
+    version: string;
+    facts: Record<string, JsonValue>;
+  };
+}
+
+// @public
+export class TechInsightsClient {
+  constructor(options: {
+    discoveryApi: DiscoveryApi;
+    identityApi: IdentityApi | AuthService;
+  });
+  getAllChecks(): Promise<Check[]>;
+  getFacts(entity: CompoundEntityRef, facts: string[]): Promise<InsightFacts>;
+  getFactSchemas(): Promise<FactSchema[]>;
+  runBulkChecks(
+    entities: CompoundEntityRef[],
+    checks?: Check[],
+  ): Promise<BulkCheckResponse>;
+  runChecks(
+    entityParams: CompoundEntityRef,
+    checks?: string[],
+  ): Promise<CheckResult[]>;
+}
+```

workspaces/tech-insights/plugins/tech-insights-common/package.json

@@ -12,9 +12,22 @@
     ]
   },
   "publishConfig": {
-    "access": "public",
-    "main": "dist/index.cjs.js",
-    "types": "dist/index.d.ts"
+    "access": "public"
+  },
+  "exports": {
+    ".": "./src/index.ts",
+    "./client": "./src/client/index.ts",
+    "./package.json": "./package.json"
+  },
+  "typesVersions": {
+    "*": {
+      "client": [
+        "src/client/index.ts"
+      ],
+      "package.json": [
+        "package.json"
+      ]
+    }
   },
   "keywords": [
     "backstage",
@@ -43,9 +56,14 @@
     "test": "backstage-cli package test"
   },
   "dependencies": {
+    "@backstage/backend-plugin-api": "^0.6.18",
+    "@backstage/catalog-model": "^1.5.0",
+    "@backstage/core-plugin-api": "^1.9.2",
+    "@backstage/errors": "^1.2.4",
     "@backstage/types": "^1.1.1",
     "@types/luxon": "^3.0.0",
-    "luxon": "^3.0.0"
+    "luxon": "^3.0.0",
+    "qs": "^6.12.3"
   },
   "devDependencies": {
     "@backstage/cli": "^0.27.0"

workspaces/tech-insights/plugins/tech-insights-common/src/client/TechInsightsClient.ts

@@ -0,0 +1,165 @@
+/*
+ * Copyright 2024 The Backstage Authors
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+import {
+  BulkCheckResponse,
+  CheckResult,
+  FactSchema,
+} from '@backstage-community/plugin-tech-insights-common';
+import { Check, InsightFacts } from './types';
+import { DiscoveryApi, IdentityApi } from '@backstage/core-plugin-api';
+import { ResponseError } from '@backstage/errors';
+import {
+  CompoundEntityRef,
+  stringifyEntityRef,
+} from '@backstage/catalog-model';
+import qs from 'qs';
+import { AuthService } from '@backstage/backend-plugin-api';
+
+/**
+ * Client to fetch data from tech-insights backend
+ *
+ * @public */
+export class TechInsightsClient {
+  private readonly discoveryApi: DiscoveryApi;
+  private readonly identityApi: IdentityApi | AuthService;
+
+  constructor(options: {
+    discoveryApi: DiscoveryApi;
+    identityApi: IdentityApi | AuthService;
+  }) {
+    this.discoveryApi = options.discoveryApi;
+    this.identityApi = options.identityApi;
+  }
+
+  /**
+   * Get facts for a specific entity
+   * @param entity - a component reference
+   * @param facts - a list fact ids to fetch
+   * @public
+   */
+  async getFacts(
+    entity: CompoundEntityRef,
+    facts: string[],
+  ): Promise<InsightFacts> {
+    const query = qs.stringify({
+      entity: stringifyEntityRef(entity),
+      ids: facts,
+    });
+    return await this.api<InsightFacts>(`/facts/latest?${query}`);
+  }
+
+  /**
+   * Get all checks.
+   * This will not return the actual status, but only metadata. To get the status use the /run endpoint
+   * @public
+   */
+  async getAllChecks(): Promise<Check[]> {
+    return this.api('/checks');
+  }
+
+  /**
+   * Get schemas of facts.
+   * Use this for example to understand what the return values will be
+   * @public
+   */
+  async getFactSchemas(): Promise<FactSchema[]> {
+    return this.api('/fact-schemas');
+  }
+
+  /**
+   * Run checks for a specific entity
+   * @param entityParams - reference to an entity
+   * @param checks - IDs of checks to run
+   * @public
+   */
+  async runChecks(
+    entityParams: CompoundEntityRef,
+    checks?: string[],
+  ): Promise<CheckResult[]> {
+    const { namespace, kind, name } = entityParams;
+    const requestBody = { checks };
+    return this.api(
+      `/checks/run/${encodeURIComponent(namespace)}/${encodeURIComponent(
+        kind,
+      )}/${encodeURIComponent(name)}`,
+      {
+        method: 'POST',
+        body: JSON.stringify(requestBody),
+      },
+    );
+  }
+
+  /**
+   * Return checks for multiple entities
+   * @param entities - list of entity references
+   * @param checks - list of check IDs
+   * @public
+   */
+  async runBulkChecks(
+    entities: CompoundEntityRef[],
+    checks?: Check[],
+  ): Promise<BulkCheckResponse> {
+    const checkIds = checks ? checks.map(check => check.id) : [];
+    const requestBody = {
+      entities,
+      checks: checkIds.length > 0 ? checkIds : undefined,
+    };
+    return this.api('/checks/run', {
+      method: 'POST',
+      body: JSON.stringify(requestBody),
+    });
+  }
+
+  private async api<T>(path: string, init?: RequestInit): Promise<T> {
+    const url = await this.discoveryApi.getBaseUrl('tech-insights');
+    const token = await this.getToken();
+
+    const headers: HeadersInit = new Headers(init?.headers);
+    if (!headers.has('content-type'))
+      headers.set('content-type', 'application/json');
+    if (token && !headers.has('authorization')) {
+      headers.set('authorization', `Bearer ${token}`);
+    }
+
+    const request = new Request(`${url}${path}`, {
+      ...init,
+      headers,
+    });
+
+    return fetch(request).then(async response => {
+      if (!response.ok) {
+        throw await ResponseError.fromResponse(response);
+      }
+      return response.json() as Promise<T>;
+    });
+  }
+
+  private async getToken(): Promise<string | null> {
+    let result: { token?: string | undefined };
+
+    if ('getCredentials' in this.identityApi) {
+      result = await this.identityApi.getCredentials();
+    } else {
+      result = await this.identityApi.getPluginRequestToken({
+        onBehalfOf: await this.identityApi.getOwnServiceCredentials(),
+        targetPluginId: 'tech-insights',
+      });
+    }
+
+    return result.token ?? null;
+  }
+}

workspaces/tech-insights/plugins/tech-insights-common/src/client/index.ts

@@ -0,0 +1,21 @@
+/*
+ * Copyright 2024 The Backstage Authors
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+/**
+ * API client for tech-insights
+ * @packageDocumentation
+ */
+export * from './TechInsightsClient';
+export type * from './types';

workspaces/tech-insights/plugins/tech-insights-common/src/client/setupTests.ts

@@ -0,0 +1 @@
+export {};