fix: division by zero in language stats (#2171)

* fix: division by zero in language stats Signed-off-by: Jos Ahrens <[email protected]> * Modify minor to patch version in changeset Co-authored-by: Vincenzo Scamporlino <[email protected]> Signed-off-by: Jos Ahrens <[email protected]> --------- Signed-off-by: Jos Ahrens <[email protected]> Signed-off-by: Jos Ahrens <[email protected]> Co-authored-by: Vincenzo Scamporlino <[email protected]>
backstage · Jan 16, 2025 · 46c4837 · 46c4837
1 parent 10226f1
commit 46c4837
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 3 deletions.
diff --git a/workspaces/copilot/.changeset/six-years-serve.md b/workspaces/copilot/.changeset/six-years-serve.md
@@ -0,0 +1,5 @@
+---
+'@backstage-community/plugin-copilot': patch
+---
+
+Fix division by zero in language stats
diff --git a/workspaces/copilot/plugins/copilot/src/utils/index.ts b/workspaces/copilot/plugins/copilot/src/utils/index.ts
@@ -45,14 +45,19 @@ export function getLanguageStats(metricsArray: Metric[]): LanguageStats[] {
       if (existingStats) {
         existingStats.totalSuggestions += item.suggestions_count;
         existingStats.totalAcceptances += item.acceptances_count;
-        existingStats.acceptanceRate =
-          existingStats.totalAcceptances / existingStats.totalSuggestions;
+        if (existingStats.totalSuggestions > 0) {
+          existingStats.acceptanceRate =
+            existingStats.totalAcceptances / existingStats.totalSuggestions;
+        }
       } else {
         languageStatsMap.set(item.language, {
           language: item.language,
           totalSuggestions: item.suggestions_count,
           totalAcceptances: item.acceptances_count,
-          acceptanceRate: item.acceptances_count / item.suggestions_count,
+          acceptanceRate:
+            item.suggestions_count > 0
+              ? item.acceptances_count / item.suggestions_count
+              : 0,
         });
       }
     });