Release 0.2.3

- see changelog
babyraging · Apr 30, 2020 · f8ba78c · f8ba78c
1 parent 44f75e6
commit f8ba78c
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 6 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -8,6 +8,7 @@
 
 ### Added
 - Added override predefined symbol detection (yacc)
+- Added predefined symbols to completion (yacc)
 
 ### Changed
 - Changed default value for rules region range (lex/yacc)

diff --git a/src/languages/services/yaccCompletions.ts b/src/languages/services/yaccCompletions.ts
@@ -1,5 +1,5 @@
 import { TextDocument, CompletionList, CompletionItem, CompletionItemKind, Position } from 'vscode';
-import { YACCDocument, NodeType } from '../parser/yaccParser';
+import { YACCDocument, NodeType, predefined } from '../parser/yaccParser';
 import { createScanner } from '../parser/yaccScanner';
 import { TokenType } from '../yaccLanguageTypes';
 
@@ -51,24 +51,30 @@ export function doYACCComplete(document: TextDocument, position: Position, yaccD
             if (node.nodeType === NodeType.Type)
                 Object.keys(yaccDocument.symbols).forEach((symbol) => {
                     completion = new CompletionItem(symbol)
-                    completion.detail = "symbol";
+                    completion.detail = "user defined non-terminal";
                     completion.kind = CompletionItemKind.Class;
                     result.push(completion);
                 });
             break;
         case NodeType.Rule:
             Object.keys(yaccDocument.symbols).forEach((symbol) => {
                 completion = new CompletionItem(symbol)
-                completion.detail = "symbol";
+                completion.detail = "user defined non-terminal";
                 completion.kind = CompletionItemKind.Class;
                 result.push(completion);
-            })
+            });
             Object.keys(yaccDocument.tokens).forEach((token) => {
                 completion = new CompletionItem(token)
-                completion.detail = "token";
+                completion.detail = "user defined token";
                 completion.kind = CompletionItemKind.Field;
                 result.push(completion);
-            })
+            });
+            Object.keys(predefined).forEach(key => {
+                completion = new CompletionItem(key)
+                completion.detail = "predefined symbol";
+                completion.kind = CompletionItemKind.Method;
+                result.push(completion);
+            });
             break;
         default:
             break;