Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(stakingEventWatcher): implement ADR-26 pre-approval staking flow and inclusion proof reporting #70

Merged
merged 18 commits into from
Oct 3, 2024

Conversation

Lazar955
Copy link
Member

@Lazar955 Lazar955 commented Oct 2, 2024

Summary

This PR implements the necessary changes to support the ADR-26 pre-approval staking flow.

Key Changes

  • Renaming: The unbondingWatcher has been renamed to stakingEventWatcher to reflect its broader responsibilities.
  • Functionality Updates:
    • Continues to report unbonding transactions as before.
    • Now reports inclusion proofs for staking transactions to Babylon.
  • E2E Introduced a new e2e test that verifies a delegation created without an inclusion proof will become active once the proof is provided.

Related Issue

Closes #67

@Lazar955 Lazar955 linked an issue Oct 2, 2024 that may be closed by this pull request
@Lazar955 Lazar955 changed the title feat(stakingeventwatcher): adapt to ADR 26 pre aproval feat(stakingEventWatcher): implement ADR-26 pre-approval staking flow and inclusion proof reporting Oct 3, 2024
@Lazar955 Lazar955 marked this pull request as ready for review October 3, 2024 09:49
Copy link
Collaborator

@KonradStaniec KonradStaniec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Lazar955 Lazar955 merged commit 8568281 into main Oct 3, 2024
8 checks passed
@Lazar955 Lazar955 deleted the lazar/adr-026-pre-approval branch October 3, 2024 16:32
Lazar955 added a commit that referenced this pull request Oct 7, 2024
… and inclusion proof reporting (#70)

### Summary
This PR implements the necessary changes to support the
[ADR-26](https://github.com/babylonlabs-io/pm/blob/main/adr/adr-026-pre-approval-staking-flow.md)
pre-approval staking flow.

### Key Changes
- **Renaming:** The `unbondingWatcher` has been renamed to
`stakingEventWatcher` to reflect its broader responsibilities.
- **Functionality Updates:**
  - Continues to report unbonding transactions as before.
  - Now reports inclusion proofs for staking transactions to Babylon.
- **E2E** Introduced a new e2e test that verifies a delegation created
without an inclusion proof will become active once the proof is
provided.

### Related Issue
Closes [#67](#67)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adapt vigiligante to pre-approval flow
2 participants