Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backporting T&C endpoint into phase-2 codebase #229

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Backporting T&C endpoint into phase-2 codebase #229

wants to merge 1 commit into from
+99 −8

Conversation

kirugan
Copy link
Contributor

@kirugan kirugan commented Feb 12, 2025 •
edited
Loading

Issue #225

@kirugan
Copy link
Contributor Author

kirugan commented Feb 12, 2025

It's not fully ready yet, but if you have any suggestions/corrections please let me know

jrwbabylonlab
jrwbabylonlab approved these changes Feb 14, 2025
View reviewed changes
Copy link
Collaborator

@jrwbabylonlab jrwbabylonlab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A single comment on missing the validation if it's not nil

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrwbabylonlab jrwbabylonlab jrwbabylonlab approved these changes

@jeremy-babylonlabs jeremy-babylonlabs Awaiting requested review from jeremy-babylonlabs jeremy-babylonlabs will be requested when the pull request is marked ready for review jeremy-babylonlabs is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kirugan @jrwbabylonlab