chore: handle withdrawable and withdrawn staking events #189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gusin13
force-pushed
the
188-add-staked-withdrawable-tvl
branch
from
b91d9da to
20960c9
Compare
| } | ||
|
|
||
| // HandleWithdrawntakerStats decrements the withdrawable delegations count and | ||
| // increments the withdrawn delegations count for the given staking tx hash |
There was a problem hiding this comment.
i can't think of a case where we need to know the withdrawn tvl or delegation as this number will always incrementing. more like a historical number.
If we remove this particular stat, will it make the solution a bit easier?
| StakerPkHex string `bson:"_id"` | ||
| ActiveTvl int64 `bson:"active_tvl"` | ||
| ActiveDelegations int64 `bson:"active_delegations"` | ||
| WithdrawableTvl int64 `bson:"withdrawable_tvl"` |
There was a problem hiding this comment.
I think there is a gap for the unbonding here.
If a delegation is unbonding, we deduce it from the activeTvl directly, right? but only add to the withdrawableTvl once the unbonding timelock expired.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes - #188