feat: Wallet on connect event
#686
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gbarkhatov
requested review from
0xDazzer,
jrwbabylonlab and
jeremy-babylonlabs
jeremy-babylonlabs
previously approved these changes
Feb 13, 2025
|
looks good to me, nit: i wonder if its good to have some UI feedback when detected address change |
That's a good point. @jeremy-babylonlabs could u create a ticket to track? |
0xDazzer
previously approved these changes
Feb 14, 2025
gbarkhatov
dismissed stale reviews from 0xDazzer and jeremy-babylonlabs
via
f581cba
gbarkhatov
requested review from
jrwbabylonlab,
jeremy-babylonlabs and
0xDazzer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When wallet is connected, properly uses
.connectWalletinonevents likeaccountChangedExample - this is needed when you connect with BTC wallet and change the address from
TaproottoNative SegWitor vice versaCloses babylonlabs-io/babylon-wallet-connector#188